This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Fix bug when truncating certain reports #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevoinea
commented
May 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #3103 +/- ##
==========================================
- Coverage 29.95% 29.68% -0.28%
==========================================
Files 127 301 +174
Lines 13893 35414 +21521
==========================================
+ Hits 4162 10511 +6349
- Misses 9731 24903 +15172
|
stishkin
approved these changes
May 15, 2023
chkeita
approved these changes
May 15, 2023
Porges
reviewed
May 15, 2023
Co-authored-by: George Pollard <porges@porg.es>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
I missed
ExecutableNamewhen I added the..Math.Mincode. Took the chance to factor that out into a function as well.