Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Don’t validate error codes on client side #3131

Merged
merged 9 commits into from
Jun 5, 2023

Conversation

Porges
Copy link
Member

@Porges Porges commented May 24, 2023

Stop pydantic from validating error codes returned from the service. This prevents the problem in #3129 from happening.

Include the error code name in the JSON returned from the service.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #3131 (e87dd7f) into main (db59cd3) will increase coverage by 0.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3131      +/-   ##
==========================================
+ Coverage   29.43%   30.12%   +0.68%     
==========================================
  Files         302      128     -174     
  Lines       35181    14002   -21179     
==========================================
- Hits        10357     4218    -6139     
+ Misses      24824     9784   -15040     
Impacted Files Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Model.cs 72.02% <100.00%> (+0.20%) ⬆️

... and 174 files with indirect coverage changes

@Porges
Copy link
Member Author

Porges commented May 25, 2023

Passed check-pr.

@Porges Porges enabled auto-merge (squash) June 5, 2023 22:04
AdamL-Microsoft added a commit that referenced this pull request Jun 5, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 5, 2023
@Porges Porges merged commit 9aa2519 into main Jun 5, 2023
@Porges Porges deleted the remove-error-code-validation branch June 6, 2023 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants