Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix bug for scale-in protection #3144

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

Fixes a bug where we return OneFuzzResult.Ok even if applying scale in protection wasn't OK.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

  • Only return OK if acquiring scale-in protection was successful
  • Add metrics

Validation Steps Performed

How does someone test & validate?

Will be validating in check-pr

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #3144 (7d23204) into main (98007be) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3144      +/-   ##
==========================================
- Coverage   31.61%   31.60%   -0.02%     
==========================================
  Files         308      308              
  Lines       36535    36551      +16     
==========================================
  Hits        11552    11552              
- Misses      24983    24999      +16     
Impacted Files Coverage Δ
...piService/ApiService/Functions/AgentCanSchedule.cs 0.00% <0.00%> (ø)
...ApiService/ApiService/onefuzzlib/NodeOperations.cs 22.32% <0.00%> (-0.54%) ⬇️

@tevoinea tevoinea enabled auto-merge (squash) May 31, 2023 11:49
@tevoinea tevoinea merged commit 0f6073b into microsoft:main May 31, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants