This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Port current implementation to ILogger #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevoinea
approved these changes
Jun 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
- Coverage 29.63% 29.61% -0.03%
==========================================
Files 331 332 +1
Lines 38773 38885 +112
==========================================
+ Hits 11492 11516 +24
- Misses 27281 27369 +88
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to ILogger, as discussed in meetings several times
ILogger is the de-facto interface for logging
This implementation also changes how "message" is formatted. Now full message is written out instead of formatting template, and formatting template is saved as part of Custom Dimensions
Using formatting template will improve memory performance compared to previous implementation
Due to AppInsights is still not fully baked implementation where we can have more control over it in Azure Functions. We can only support one destination to write out AppInsights. Attempting to use more than one App Insights destination - will only write data out into the first registered AppInsights