Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Try to kill debuggee if Linux recording times out #3177

Merged
merged 8 commits into from
Jun 13, 2023

Conversation

ranweiler
Copy link
Member

Closes #3174.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #3177 (2229dd6) into main (8c90419) will decrease coverage by 4.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3177      +/-   ##
==========================================
- Coverage   29.59%   25.57%   -4.03%     
==========================================
  Files         332      152     -180     
  Lines       38910    16327   -22583     
==========================================
- Hits        11516     4175    -7341     
+ Misses      27394    12152   -15242     

see 180 files with indirect coverage changes

@ranweiler ranweiler force-pushed the coverage-dangling-child branch from 5ad33bf to 0392eed Compare June 13, 2023 17:45
@ranweiler
Copy link
Member Author

Manual testing:

  • Modified coverage example to loop instead of exiting on recording errors (to allow observing dangling tracee child processes)
  • Ran coverage against a target tracee modified to hang on any input
  • Red/green testing: before changes, observed a dangling tracee subprocess on timeout. After changes, tracee was terminated across a wide range of timeout values.

@ranweiler
Copy link
Member Author

Integration tests passed, confirmed that reports look as expected.

@tevoinea tevoinea merged commit 39673be into microsoft:main Jun 13, 2023
@ranweiler ranweiler deleted the coverage-dangling-child branch June 13, 2023 20:10
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux coverage tracing thread continues after timeout
3 participants