Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Improve error reporting from scale-in protection modification #3184

Merged

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Jun 9, 2023

Summary of the Pull Request

What is this about?

Return different error codes from the different failure modes of modifying scale-in protection on a VM instance. Closes #3183

Info on Pull Request

What does this include?

  1. 4 new error codes that represent our known failure modes for modifying scale-in protection
  2. Downgrade Upgrade Already In Progress errors to a warning
  3. In the case of removing scale-in protection, downgrade Instance No Longer Exists to a warning

Validation Steps Performed

How does someone test & validate?

check-pr should not longer report errors in check logs for modifying scale-in protection

@tevoinea tevoinea requested a review from stishkin June 9, 2023 17:23
@tevoinea tevoinea requested a review from AdamL-Microsoft June 9, 2023 17:27
@tevoinea tevoinea enabled auto-merge (squash) June 9, 2023 19:27
@codecov-commenter
Copy link

Codecov Report

Merging #3184 (25ccdfd) into main (a040aa2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3184      +/-   ##
==========================================
- Coverage   29.60%   29.59%   -0.01%     
==========================================
  Files         332      332              
  Lines       38902    38910       +8     
==========================================
  Hits        11516    11516              
- Misses      27386    27394       +8     
Impacted Files Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Enums.cs 32.39% <ø> (ø)
...ApiService/ApiService/onefuzzlib/NodeOperations.cs 19.29% <0.00%> (-0.35%) ⬇️
...ApiService/ApiService/onefuzzlib/VmssOperations.cs 0.00% <0.00%> (ø)

@tevoinea tevoinea merged commit 8c90419 into microsoft:main Jun 9, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downgrade certain errors to warnings when modifying scale-in protection
3 participants