This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Resolving Regression Bugs - File Bugs on regression_report
and properly reset state on duplicate.
#3263
Merged
nharper285
merged 11 commits into
microsoft:main
from
nharper285:user/noharper/regression-bug-2
Jul 5, 2023
Merged
Resolving Regression Bugs - File Bugs on regression_report
and properly reset state on duplicate.
#3263
nharper285
merged 11 commits into
microsoft:main
from
nharper285:user/noharper/regression-bug-2
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3263 +/- ##
==========================================
- Coverage 29.65% 29.65% -0.01%
==========================================
Files 332 332
Lines 39296 39302 +6
==========================================
Hits 11654 11654
- Misses 27642 27648 +6
|
stishkin
reviewed
Jun 29, 2023
stishkin
reviewed
Jun 29, 2023
stishkin
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd wait for Teo's feedback though before merging
Porges
reviewed
Jul 3, 2023
tevoinea
approved these changes
Jul 5, 2023
…harper285/onefuzz into user/noharper/regression-bug-2
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
We were not filing (or updating) bugs for regression reports.
Separately, there was a bug in our notification logic that prevented bugs from having their state reset.
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?