This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
By default,
azcopy
can consume an unbounded amount of RAM.In conjunction with any other jobs or processes running that also consume a huge amount of RAM, this can cause the system to reach out-of-memory conditions and cause random processes to fail.
However,
azcopy
will query the system for an environment variable namedAZCOPY_BUFFER_GB
.If found, it will limit its internal memory consumption to whatever is specified by that environment variable.
So, we can simply declare that environment variable and limit memory consumption to something reasonable.
From local testing, I have found that half a gigabyte to be a reasonable limit (with the option to decrease the buffer size to something even smaller if necessary).
PR Checklist
References
https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-optimize#optimize-memory-use
Azure/azure-storage-azcopy#802
Azure/azure-storage-azcopy#1215