Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Storage performance fixes #3313

Merged
merged 15 commits into from
Jul 24, 2023
Merged

Storage performance fixes #3313

merged 15 commits into from
Jul 24, 2023

Conversation

Porges
Copy link
Member

@Porges Porges commented Jul 20, 2023

Noticed a few things while doing #3304, so fixing them in another PR:

  • Add CreateNewContainer which will always create a new container instead of looking for one first.
  • InstanceId was not being cached properly (the Lazy would be recreated upon every request) — my fault!
  • Add GetBlob beside GetBlogWithTags for when we don't need the tags
  • Make GetBlogWithTags do both fetches in parallel

@Porges Porges marked this pull request as ready for review July 20, 2023 01:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #3313 (8361359) into main (e68fc45) will increase coverage by 0.03%.
The diff coverage is 86.53%.

@@            Coverage Diff             @@
##             main    #3313      +/-   ##
==========================================
+ Coverage   31.80%   31.83%   +0.03%     
==========================================
  Files         307      307              
  Lines       37334    37357      +23     
==========================================
+ Hits        11874    11894      +20     
- Misses      25460    25463       +3     
Files Changed Coverage Δ
src/ApiService/ApiService/Functions/Jobs.cs 73.46% <83.33%> (+1.02%) ⬆️
src/ApiService/ApiService/onefuzzlib/Containers.cs 69.85% <86.84%> (+1.17%) ⬆️
src/ApiService/ApiService/Functions/Containers.cs 87.67% <100.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Events.cs 70.68% <100.00%> (ø)

Base automatically changed from cache-findcontainer to main July 20, 2023 21:03
@Porges Porges merged commit 9f234a1 into main Jul 24, 2023
@Porges Porges deleted the perf-storage branch July 24, 2023 23:24
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants