Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Differentiate INVALID_JOB and INVALID_TASK error codes #3318

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

kananb
Copy link
Contributor

@kananb kananb commented Jul 20, 2023

Summary of the Pull Request

Differentiate between INVALID_JOB and INVALID_TASK error codes so that the CLI doesn't always assume INVALID_TASK.
#3276

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

Deployed the change manually and validated with onefuzz jobs get <invalid_jobid>

@kananb kananb requested review from Porges and chkeita July 20, 2023 22:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #3318 (498c861) into main (51591b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3318   +/-   ##
=======================================
  Coverage   31.78%   31.78%           
=======================================
  Files         307      307           
  Lines       37312    37312           
=======================================
  Hits        11860    11860           
  Misses      25452    25452           
Impacted Files Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Enums.cs 32.39% <ø> (ø)

@kananb kananb force-pushed the kanan/job-get-error branch from fcbc324 to 498c861 Compare July 20, 2023 23:20
@kananb kananb merged commit 956474e into main Jul 20, 2023
@kananb kananb deleted the kanan/job-get-error branch July 20, 2023 23:29
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants