Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix 'missing' dependency #3331

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

opentelemetry claims requests ~= 2.0 is not installed with the following message:

DependencyConflict: requested: "requests ~= 2.0" but found: "None"

This is false however, requests is installed and we should leave it up to pip to decide what's installed or not.

@tevoinea tevoinea enabled auto-merge (squash) July 24, 2023 19:42
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Merging #3331 (75deae6) into main (85002a6) will decrease coverage by 2.38%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3331      +/-   ##
==========================================
- Coverage   34.18%   31.81%   -2.38%     
==========================================
  Files         141      307     +166     
  Lines       17413    37327   +19914     
==========================================
+ Hits         5952    11874    +5922     
- Misses      11461    25453   +13992     
Files Changed Coverage Δ
...Service/ApiService/onefuzzlib/notifications/Ado.cs 9.58% <0.00%> (ø)
...piService/onefuzzlib/notifications/GithubIssues.cs 0.00% <0.00%> (ø)
...vice/onefuzzlib/notifications/NotificationsBase.cs 73.50% <92.85%> (ø)
...e/onefuzzlib/notifications/JinjaTemplateAdapter.cs 90.86% <100.00%> (ø)

... and 185 files with indirect coverage changes

@tevoinea tevoinea merged commit 2d0d297 into microsoft:main Jul 24, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants