Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix state management in the scheduler #337

Merged
13 commits merged into from
Nov 24, 2020
Merged

Fix state management in the scheduler #337

13 commits merged into from
Nov 24, 2020

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Nov 20, 2020 •
edited by bmc-msft
Loading

No description provided.

@chkeita chkeita linked an issue Nov 20, 2020 that may be closed by this pull request
Agent SettingUp event and setup errors are not being sent to the service #333
Closed
@chkeita chkeita requested a review from bmc-msft November 20, 2020 22:22
@chkeita chkeita marked this pull request as ready for review November 20, 2020 22:23
@bmc-msft bmc-msft requested a review from ranweiler November 20, 2020 22:34
@bmc-msft
Copy link
Contributor

Given @ranweiler's experience with the state machine code, I added them to review this PR.

@bmc-msft bmc-msft removed their request for review November 20, 2020 22:37
@bmc-msft
Copy link
Contributor

Note, this passed the integration tests.

ranweiler
ranweiler approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@ranweiler ranweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some unit tests to validate this going forward?

It should just require adding some test cases here to ensure that the right events get pushed (or not) to the events field of CoordinatorDouble, depending on the initial state.

@ranweiler
Copy link
Member

@chkeita, is it correct that you can now manually observe all expected events being received by the service handler? I.e. in a normal job with no setup script, transitions from init to free to setting_up to pending to busy to done?

@chkeita chkeita requested a review from ranweiler November 23, 2020 21:21
@ghost
Copy link

ghost commented Nov 24, 2020

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d47124f into microsoft:main Nov 24, 2020
@chkeita chkeita deleted the chkeita/333 branch March 31, 2021 21:52
@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ranweiler ranweiler ranweiler approved these changes

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent SettingUp event and setup errors are not being sent to the service
3 participants
@chkeita @bmc-msft @ranweiler