This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Tolerate errors when attempting to fetch metadata for some CreateKind
s
#3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrChat
changed the title
Tolerate errors when attempting to fetch metadata some
Tolerate errors when attempting to fetch metadata for some Aug 8, 2023
CreateKind
CreateKind
s
…y` or `CreateKind::Other`
DrChat
force-pushed
the
user/jusmoore/metacheck
branch
from
August 8, 2023 14:53
de7a4c4
to
2e44020
Compare
Codecov Report
@@ Coverage Diff @@
## main #3393 +/- ##
==========================================
- Coverage 34.68% 34.68% -0.01%
==========================================
Files 302 302
Lines 36920 36923 +3
==========================================
+ Hits 12805 12806 +1
- Misses 24115 24117 +2
|
DrChat
force-pushed
the
user/jusmoore/metacheck
branch
from
August 8, 2023 16:20
062211b
to
8a0e980
Compare
chkeita
reviewed
Aug 8, 2023
chkeita
approved these changes
Aug 8, 2023
chkeita
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to run check-pr before merging.
DrChat
force-pushed
the
user/jusmoore/metacheck
branch
from
August 8, 2023 17:51
d23cf29
to
54f97a7
Compare
chkeita
reviewed
Aug 8, 2023
DrChat
force-pushed
the
user/jusmoore/metacheck
branch
from
August 8, 2023 18:11
da34b0f
to
48a61e6
Compare
Porges
reviewed
Aug 8, 2023
chkeita
approved these changes
Aug 8, 2023
Porges
approved these changes
Aug 8, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixing an error encountered in prod:
PR Checklist