Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Tolerate errors when attempting to fetch metadata for some CreateKinds #3393

Merged
merged 7 commits into from
Aug 8, 2023

Conversation

DrChat
Copy link
Member

@DrChat DrChat commented Aug 8, 2023

Summary of the Pull Request

Fixing an error encountered in prod:

task failed. exit_status:ExitStatus { Code = 1, Signal = , Success = False }

ERROR [onefuzz_task::managed::cmd] error running task: Failure in monitor_inputs

Caused by:
    0: checking metadata for file
    1: The system cannot find the file specified. (os error 2)

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

@DrChat DrChat changed the title Tolerate errors when attempting to fetch metadata some CreateKind Tolerate errors when attempting to fetch metadata for some CreateKinds Aug 8, 2023
@DrChat DrChat force-pushed the user/jusmoore/metacheck branch from de7a4c4 to 2e44020 Compare August 8, 2023 14:53
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #3393 (acebd02) into main (8980988) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #3393      +/-   ##
==========================================
- Coverage   34.68%   34.68%   -0.01%     
==========================================
  Files         302      302              
  Lines       36920    36923       +3     
==========================================
+ Hits        12805    12806       +1     
- Misses      24115    24117       +2     
Files Changed Coverage Δ
src/agent/onefuzz/src/monitor.rs 79.78% <75.00%> (-1.54%) ⬇️

@DrChat DrChat force-pushed the user/jusmoore/metacheck branch from 062211b to 8a0e980 Compare August 8, 2023 16:20
@DrChat DrChat requested a review from chkeita August 8, 2023 17:43
Copy link
Contributor

@chkeita chkeita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to run check-pr before merging.

@DrChat DrChat force-pushed the user/jusmoore/metacheck branch from d23cf29 to 54f97a7 Compare August 8, 2023 17:51
@DrChat DrChat force-pushed the user/jusmoore/metacheck branch from da34b0f to 48a61e6 Compare August 8, 2023 18:11
@DrChat DrChat requested a review from chkeita August 8, 2023 19:19
@DrChat DrChat requested a review from Porges August 8, 2023 20:35
@Porges Porges merged commit 3851ab0 into microsoft:main Aug 8, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants