Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Capture required args and make it match cli #3429

Merged

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Aug 17, 2023

Summary of the Pull Request

What is this about?

Closes #3427

The libfuzzer-fuzz local task has the following required arguments:

execute a local-only libfuzzer fuzzing task

Usage: onefuzz-task local libfuzzer-fuzz [OPTIONS] --target_exe <target_exe> --inputs_dir <inputs_dir> --crashes_dir <crashes_dir> --crashdumps_dir <crashdumps_dir>

This PR updates our libfuzzer-fuzz basic yaml template to those required arguments. It also adds one more, coverage argument.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #3429 (558d555) into main (98e986e) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   33.91%   33.90%   -0.01%     
==========================================
  Files         297      297              
  Lines       36770    36770              
==========================================
- Hits        12470    12467       -3     
- Misses      24300    24303       +3     
Files Changed Coverage Δ
...c/agent/onefuzz-task/src/local/generic_analysis.rs 0.66% <0.00%> (-0.01%) ⬇️
src/agent/onefuzz-task/src/local/template.rs 11.80% <40.00%> (-1.99%) ⬇️

@tevoinea tevoinea requested review from chkeita and Porges August 17, 2023 19:07
@chkeita
Copy link
Contributor

chkeita commented Aug 17, 2023

My initial comment was about matching the onefuzz cli template command. So, we also need the regression and analysis tasks in the template.

@tevoinea
Copy link
Member Author

My initial comment was about matching the onefuzz cli template command. So, we also need the regression and analysis tasks in the template.

Ah I misunderstood, updated to match the libfuzzer_basic cli template. I added the regression task and since the analysis task is optional, I included it but commented out. I also found a bug in a mismatch of the required args (tools was supposed to be optional so I fixed that).

@tevoinea tevoinea enabled auto-merge (squash) August 21, 2023 13:24
@tevoinea tevoinea merged commit 8fc2f83 into microsoft:main Aug 21, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make libfuzzer basic template match CLI args
4 participants