Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix deployment of backdated versions of OneFuzz #347

Merged
12 commits merged into from
Dec 1, 2020

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented Nov 30, 2020

When running automated deployments, 'tools' were not being properly replaced with the updated versions if the deployment was created prior to the original instance deployment.

@bmc-msft
Copy link
Contributor

@nharper285, your github account isn't part of the Microsoft org. You should link your account, which will remove your need to sign the NDA.

https://opensource.microsoft.com/link

@bmc-msft
Copy link
Contributor

This fails with the error Error: unknown flag: --delete-destination

@bmc-msft
Copy link
Contributor

Unfortunately, azcopy copy and azcopy sync are not directly drop in replacements.

azcopy copy tools https://contoso.com/tools?sas uploads the files to https://contoso.com/tools/tools/
azcopy sync tools https://contoso.com/tools?sas uploads the files to https://contoso.com/tools/

src/deployment/deploy.py Outdated Show resolved Hide resolved
src/deployment/deploy.py Outdated Show resolved Hide resolved
src/deployment/deploy.py Outdated Show resolved Hide resolved
src/deployment/deploy.py Outdated Show resolved Hide resolved
src/deployment/deploy.py Outdated Show resolved Hide resolved
src/deployment/deploy.py Outdated Show resolved Hide resolved
src/deployment/deploy.py Outdated Show resolved Hide resolved
@bmc-msft
Copy link
Contributor

Integration test in progress.

@bmc-msft bmc-msft changed the title Changing azcopy param from 'sync' to 'copy' to resolve timestamp update issues. Fix deployment of backdated versions of OneFuzz Dec 1, 2020
@ghost
Copy link

ghost commented Dec 1, 2020

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 10 hours 24 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5092f96 into microsoft:main Dec 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@nharper285 nharper285 deleted the user/noharper/deploy-azcopy-update branch October 20, 2021 16:30
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants