Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fixup onefuzz-task dependencies #3552

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Fixup onefuzz-task dependencies #3552

merged 3 commits into from
Oct 5, 2023

Conversation

Porges
Copy link
Member

@Porges Porges commented Oct 5, 2023

Both the bin and lib for onefuzz-task include the same modules, which means some code is being compiled twice, and this leads to confusing errors if you update the bin code and not the lib code (e.g. adding new modules or something similar).

Instead, make the bin code depend on the lib code.

Also remove extern crate and macro_use, which are an older way of doing things. Macros are simply imported now.

@Porges Porges marked this pull request as ready for review October 5, 2023 21:10
@Porges Porges requested a review from kananb October 5, 2023 21:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #3552 (3e85571) into main (003c9ac) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3552   +/-   ##
=======================================
  Coverage   38.97%   38.97%           
=======================================
  Files         301      301           
  Lines       36848    36848           
=======================================
  Hits        14363    14363           
  Misses      22485    22485           
Files Coverage Δ
src/agent/onefuzz-task/src/check_for_update.rs 0.00% <ø> (ø)
src/agent/onefuzz-task/src/managed/cmd.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/main.rs 0.00% <0.00%> (ø)

@Porges Porges merged commit 8d957ce into main Oct 5, 2023
24 checks passed
@Porges Porges deleted the fixup-onefuzz-task-layout branch October 5, 2023 21:28
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants