This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Add a GetExpand
trait for initializing Expand
objects in our tasks
#3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kananb
force-pushed
the
kanan/expand-all
branch
from
October 5, 2023 22:13
71bd182
to
53b0043
Compare
Codecov Report
@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
+ Coverage 39.01% 39.96% +0.95%
==========================================
Files 302 303 +1
Lines 36963 37635 +672
Branches 0 1721 +1721
==========================================
+ Hits 14421 15042 +621
+ Misses 22542 22274 -268
- Partials 0 319 +319
|
tevoinea
reviewed
Oct 10, 2023
tevoinea
reviewed
Oct 10, 2023
tevoinea
reviewed
Oct 10, 2023
tevoinea
reviewed
Oct 10, 2023
* Remove the retention policy setting (#3452) --------- Co-authored-by: Cheick Keita <chkeita@microsoft.com>
kananb
force-pushed
the
kanan/expand-all
branch
from
October 12, 2023 18:47
c68b673
to
7f0a510
Compare
chkeita
approved these changes
Oct 13, 2023
Porges
reviewed
Oct 15, 2023
Porges
reviewed
Oct 15, 2023
Porges
reviewed
Oct 15, 2023
- Stop initializing target_exe in get_expand() for the dotnet coverage task since it's overwritten when the expander is used. - Expand the inputs field from the generic merge task as generated_inputs.
… into kanan/expand-all
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Implements a slightly more standardized way for initializing
Expand
objects by adding aGetExpand
trait that defines a similarly named function. Each config then implements it to generate theExpand
object.Property-based unit tests are also added to ensure that all of the variables that are expected to be available for expansion, in fact, are.
A few things that could use further consideration:
target_exe
in the generic coverage task.generated_inputs
andinput_corpus
in the generator task.runtime_dir
andcrashes
in the supervisor task.generated_inputs
in the merge task.Expand
object. I'm not sure how to accommodate this from the trait implementation when the value is calculated using only config fields.target_exe
in the analysis task.target_exe
in the dotnet coverage task.target_exe
in the supervisor task.target_exe
in the merge task.Expand
object that overrides the value that was passed from the config.target_exe
andreports_dir
in the analysis task.target_exe
in the dotnet coverage task.input_corpus
,reports_dir
, andcrashdumps
in the supervisor task.mightprobably have done some silly things without realizing.PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?