This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Report when coverage is empty #3609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
reviewed
Oct 30, 2023
| @@ -174,7 +175,7 @@ impl CoverageTask { | |||
| context.save_and_sync_coverage().await?; | |||
| } | |||
|
|
|||
| info!("report coverage"); | |||
| info!("report final coverage"); | |||
There was a problem hiding this comment.
this is not the final coverage.
the task can still report coverage in the loop that reads from the queue.
chkeita
reviewed
Oct 30, 2023
| @@ -447,6 +452,8 @@ impl<'a> TaskContext<'a> { | |||
| if count % 10 == 0 { | |||
| self.save_and_sync_coverage().await?; | |||
| } | |||
| info!("report coverage"); | |||
There was a problem hiding this comment.
don't emit this event here. At this point the coverage is is not really reported yet because we have no update the files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?