Verify a workset only exists along with a reboot context #378

bmc-msft · 2020-12-10T13:39:39Z

Adds the following:

Serializes a workset to disk during setup.
Upon deserializing a RebootContext, delete the file from disk (We support rebooting once and only once)
Check if a workset exists with a RebootContext
1. If True, continuing processing
2. if False, mark the tasks & node as "Done" with appropriate errors via:
  1. send WorkerEvent::Done events for each of the tasks in the work set
  2. send StateUpdateEvent::Done for the node

bmc-msft · 2020-12-10T19:32:18Z

This passed basic integration tests, but none of those do a reboot.

This PR should update the integration tests to one of the tests to enable reboot_after_setup.

src/agent/onefuzz-supervisor/src/work.rs

src/agent/onefuzz-supervisor/src/main.rs

ghost · 2021-01-04T17:31:24Z

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Verify a workset only exists along with a reboot context

07ed75c

This was linked to issues Dec 10, 2020

setup script failures don't mark the workset as failed #377

Closed

agent-supervisor claims additional work after failing #376

Closed

bmc-msft removed a link to an issue Dec 10, 2020

setup script failures don't mark the workset as failed #377

Closed

bmc-msft mentioned this pull request Dec 10, 2020

setup script failures don't mark the workset as failed #377

Closed

bmc-msft and others added 2 commits December 10, 2020 15:50

Merge branch 'main' into check-existing-worksets

f9b43f1

add reboot after setup to libfuzzer-linux test

be2f99b

bmc-msft added the passed-integration-tests label Dec 18, 2020

ranweiler approved these changes Jan 4, 2021

View reviewed changes

src/agent/onefuzz-supervisor/src/work.rs Outdated Show resolved Hide resolved

src/agent/onefuzz-supervisor/src/work.rs Outdated Show resolved Hide resolved

ranweiler reviewed Jan 4, 2021

View reviewed changes

src/agent/onefuzz-supervisor/src/main.rs Show resolved Hide resolved

ranweiler reviewed Jan 4, 2021

View reviewed changes

src/agent/onefuzz-supervisor/src/main.rs Show resolved Hide resolved

demoray and others added 3 commits January 4, 2021 12:18

add additional context to log

58c1da7

add explainations per feedback

7df7325

Merge branch 'main' into check-existing-worksets

9b57274

bmc-msft added the auto-merge label Jan 4, 2021

ghost merged commit d038cca into microsoft:main Jan 4, 2021

bmc-msft deleted the check-existing-worksets branch January 20, 2021 11:11

ghost locked as resolved and limited conversation to collaborators Apr 17, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Verify a workset only exists along with a reboot context #378

Verify a workset only exists along with a reboot context #378

bmc-msft commented Dec 10, 2020

bmc-msft commented Dec 10, 2020

ghost commented Jan 4, 2021

Verify a workset only exists along with a reboot context #378

Verify a workset only exists along with a reboot context #378

Conversation

bmc-msft commented Dec 10, 2020

bmc-msft commented Dec 10, 2020

ghost commented Jan 4, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.