Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

set more detailed version information during builds #58

Merged
merged 5 commits into from
Sep 30, 2020
Merged

set more detailed version information during builds #58

merged 5 commits into from
Sep 30, 2020

Conversation

bmc-msft
Copy link
Contributor

Summary of the Pull Request

Unless Onefuzz is built in Github from a 'refs/tags', append the SHA and potentially .localchanges to the version string.

This provides an easy marker for identifying if the system has local changes included or not.

Info on Pull Request

  • Updates the each of the build.rs to to check GITHUB_REF and git diff --quiet to identify local changes
  • Adds a util to reset setting versions (reset-versions.sh)
  • Adds a util to get the version string without setting it (get-version.sh)
  • Updates the service API deploy-dev.sh to package onefuzztypes & the api with the stamped in build strings

Validation Steps Performed

Manual inspection of built artifacts. Locally built should be:

  • 1.0.0-HASH or 1.0.0-HASH.localchanges in the case of modifying code locally without checking it in.
  • CI builds should be 1.0.0-HASH
  • Tag builds should be 1.0.0

src/proxy-manager/build.rs Outdated Show resolved Hide resolved
@bmc-msft bmc-msft merged commit 24f4347 into microsoft:main Sep 30, 2020
@bmc-msft bmc-msft deleted the set-version-on-build branch September 30, 2020 22:54
anshuman-goel pushed a commit to anshuman-goel/onefuzz that referenced this pull request Oct 1, 2020
anshuman-goel added a commit to anshuman-goel/onefuzz that referenced this pull request Oct 6, 2020
* newer onefuzz type

* update to types

* scaling

* optional region

* region as optional

* pool as mandatory

* cap case

* newer changes

* idk

* af errors

* pool debugging

* region cap case

* task state

* Update `can_schedule` check to support node reimaging (microsoft#35)

- Include version in `can_schedule` check, expect rich response
- Check if work can be scheduled before claiming
- If work is stopped, claim and drop it
- If node is outdated, don't claim work

* Refactor internal node event schemas (microsoft#29)

* use sccache more consistently  (microsoft#47)

- Uses actions/cache via `src/ci/rust-prereqs.sh` to cache installing multiple rust prereqs including `cargo-audit` and `sccache`
- Uses actions/cache to cache `src/agent/target` and `src/proxy-manager/target` 

Co-authored-by: Brian Caswell <bmc@shmoo.com>

* add end-to-end integration testing of fuzzing pipelines (microsoft#46)

* re-add black to lint stages (microsoft#45)

* fix formatting (microsoft#55)

* Example sdk in azure functions (microsoft#56)

* Adding node assignment to the task entity (microsoft#54)

* Link VMSS nodes and tasks when setting up (microsoft#43)

Add a (backwards-compatible) data field to node state update events. Use this to link nodes and tasks as soon as the tasks have been claimed. Add a new task-level `setting_up` state to encode this.

* set more detailed version information during builds (microsoft#58)

* Using a clean flag (microsoft#59)

Locally adding `--clean` to the command helps in making a exe w/o caching.

* Remove use of `batch` in NodeMessages (microsoft#60)

* make version.localchanges match API logic (microsoft#62)

* Set log levels in Azure Functions by hand for 3rd party libraries (microsoft#63)

* use sc.exe instead of Set-Content (microsoft#67)

* move to warning (microsoft#66)

* slim down msg (microsoft#65)

* only set stating to stopping (microsoft#64)

* setting a default

* reversing things

* agent comment

* debugging

* scaling down

* fixing resizes

* Build 1.1.0 (microsoft#99)

* Update CURRENT_VERSION (microsoft#104)

* newer changes

* api fix

* removing onefuzztypes

* linter errors

* syntax error

* sorting imports

* linter

* linter

* linting fixes

* linting fixes

* import sort

* linting fixes

* linting fixes

* fixes

* removing non needed changes

* model remove non needed changes

Co-authored-by: Joe Ranweiler <joranwei@microsoft.com>
Co-authored-by: bmc-msft <41130664+bmc-msft@users.noreply.github.com>
Co-authored-by: Brian Caswell <bmc@shmoo.com>
Co-authored-by: Cheick Keita <kcheick@gmail.com>
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants