This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
fix bool queries #597
Merged
fix bool queries #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
changed the title
ranweiler
approved these changes
Feb 25, 2021
| parts.append("%s eq %s" % (field_name, str(x).lower)) | ||
| if isinstance(values[0], int): | ||
| parts.append("%s eq %s" % (field_name, str(x).lower())) | ||
| elif isinstance(values[0], int): |
There was a problem hiding this comment.
Confirming: this shouldn't actually matter, since bool is not a subclass of int. You are just updating this to be consistent with the larger control flow here, which is conceptually a big match.
There was a problem hiding this comment.
Unfortunately, bool is a subclass of int. This was generating queries that were field == 0, where we needed field eq false
Python 3.8.5 (default, Jan 27 2021, 15:41:15)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> a = False
>>> isinstance(a, int)
True
>>>
| @@ -148,8 +148,8 @@ def build_filters( | |||
| for x in values: | |||
| if not isinstance(x, bool): | |||
| raise TypeError("unexpected type") | |||
| parts.append("%s eq %s" % (field_name, str(x).lower)) | |||
| if isinstance(values[0], int): | |||
| parts.append("%s eq %s" % (field_name, str(x).lower())) | |||
There was a problem hiding this comment.
This is where the actual bug was.
There was a problem hiding this comment.
This is a two-part bug.
chkeita
approved these changes
Feb 25, 2021
|
Hello @bmc-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses broken queries used for identifying outdated nodes.