This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
add context to logging of supervisor work queue interaction #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes the changes from #602 to enable builds |
…ft/onefuzz into add-workset-queue-context-logging
ranweiler
approved these changes
Feb 27, 2021
| @@ -159,25 +162,25 @@ impl WorkQueue { | |||
| // it was just due to a stale SAS URL. | |||
| if let Err(err) = &msg { | |||
| if is_auth_error(err) { | |||
| self.renew().await?; | |||
| self.renew().await.context("unable to renew registration")?; | |||
There was a problem hiding this comment.
Distinguish this context (renewal attempt due to auth error) from the above.
ranweiler
approved these changes
Feb 28, 2021
bmc-msft
pushed a commit
to bmc-msft/onefuzz
that referenced
this pull request
Feb 28, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.