Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add salvo telemetry #619

Merged
12 commits merged into from
Mar 12, 2021
Merged

Add salvo telemetry #619

12 commits merged into from
Mar 12, 2021

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Mar 1, 2021 •
edited
Loading

Adds telemetry fields for Salvo.

This PR should not be merged until approved by CELA.

Note: This PR includes #586

@bmc-msft bmc-msft requested review from chkeita and ranweiler March 1, 2021 21:24
@bmc-msft bmc-msft requested a review from lzybkr March 1, 2021 22:07
lzybkr
lzybkr approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@lzybkr lzybkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Did you test the build with the optional features enabled?
Also note - the z3-sys crate build is quite slow, so we'll notice quickly if build artifact caching isn't working.

@bmc-msft
Copy link
Contributor Author

bmc-msft commented Mar 1, 2021

Changes look good.
Did you test the build with the optional features enabled?

I built it locally. I've not added it to CICD, though I'll do that now.

Also note - the z3-sys crate build is quite slow, so we'll notice quickly if build artifact caching isn't working.

@bmc-msft bmc-msft marked this pull request as ready for review March 11, 2021 22:09
@bmc-msft bmc-msft added this to the 3.0.0 milestone Mar 12, 2021
@bmc-msft
Copy link
Contributor Author

This PR is blocked by #671

ranweiler
ranweiler suggested changes Mar 12, 2021
View reviewed changes
src/agent/onefuzz-telemetry/src/lib.rs Outdated Show resolved Hide resolved
src/agent/onefuzz-telemetry/src/lib.rs Outdated Show resolved Hide resolved
src/agent/onefuzz-telemetry/src/lib.rs Show resolved Hide resolved
@bmc-msft bmc-msft requested a review from ranweiler March 12, 2021 19:11
@ghost
Copy link

ghost commented Mar 12, 2021

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ff3e80f into microsoft:main Mar 12, 2021
@bmc-msft bmc-msft deleted the add-salvo-telemetry branch March 19, 2021 15:41
@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lzybkr lzybkr lzybkr approved these changes

@ranweiler ranweiler ranweiler approved these changes

@chkeita chkeita chkeita approved these changes

Assignees
No one assigned
Labels
auto-merge passed-integration-tests
Projects
None yet
Milestone
local-fuzzing
Development

Successfully merging this pull request may close these issues.
5 participants
@bmc-msft @chkeita @ranweiler @lzybkr @demoray