Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

mark dependant tasks failed upon failure #650

Merged
4 commits merged into from
Mar 11, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/api-service/__app__/onefuzzlib/tasks/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ def mark_stopping(self) -> None:
)
)

def mark_failed(self, error: Error) -> None:
def mark_failed(
self, error: Error, tasks_in_job: Optional[List["Task"]] = None
) -> None:
if self.state in [TaskState.stopped, TaskState.stopping]:
logging.debug(
"ignoring post-task stop failures for %s:%s", self.job_id, self.task_id
Expand All @@ -224,6 +226,25 @@ def mark_failed(self, error: Error) -> None:
)
)

self.mark_dependants_failed(tasks_in_job=tasks_in_job)

def mark_dependants_failed(
self, tasks_in_job: Optional[List["Task"]] = None
) -> None:
if tasks_in_job is None:
tasks_in_job = Task.search(query={"job_id": [self.job_id]})

for task in tasks_in_job:
if task.config.prereq_tasks:
if self.task_id in task.config.prereq_tasks:
task.mark_failed(
Error(
code=ErrorCode.TASK_FAILED,
errors=["prerequisite task failed"],
),
tasks_in_job,
)

def get_pool(self) -> Optional[Pool]:
if self.config.pool:
pool = Pool.get_by_name(self.config.pool.pool_name)
Expand Down