Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

include the full failure when we give up from retrying #696

Merged

Conversation

bmc-msft
Copy link
Contributor

Previously, after 4 attempts, we'd raise the error request failed after {} attempts without the underlying error context from reqwest. This moves to raising the underlying error, but with context that it failed after N attempts.

@bmc-msft bmc-msft requested a review from chkeita March 18, 2021 22:46
@ghost
Copy link

ghost commented Mar 18, 2021

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 17 hours 5 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@bmc-msft bmc-msft merged commit d57abb6 into microsoft:main Mar 19, 2021
@bmc-msft bmc-msft deleted the include-last-failure-on-retry-failure branch March 19, 2021 15:37
@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants