This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
add symbol and module names to StackFrame #723
Merged
21 commits merged into
microsoft:main
from
bmc-msft:include-symbol-module-names-stack-frame
Mar 24, 2021
Merged
add symbol and module names to StackFrame #723
21 commits merged into
microsoft:main
from
bmc-msft:include-symbol-module-names-stack-frame
Mar 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes the module_info and symbol name from debugger in the StackFrame
Current output: {
"crash_report": {
"input_sha256": "8abb9b1b07f17b5442c5d71b38eaf599ddd37fa38a3062c709a7e68412e57922",
"executable": "C:\\Users\\bcaswell\\projects\\test-artifacts\\windows-trivial-crash\\fuzz.exe",
"crash_type": "WriteAccessViolation",
"crash_site": "fuzz!strncpy minkernel\\crts\\ucrt\\src\\appcrt\\string\\amd64\\strncpy.asm:46",
"call_stack": [
"fuzz!strncpy minkernel\\crts\\ucrt\\src\\appcrt\\string\\amd64\\strncpy.asm:46",
"fuzz!check D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:21",
"fuzz!from_file D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:67",
"<corrupt frame(s)>"
],
"call_stack_sha256": "8c0026819742a73973b587fd9e18545b1fd2770ebd65b9141f24bcc6c4e47b9c",
"minimized_stack": [
"fuzz!strncpy minkernel\\crts\\ucrt\\src\\appcrt\\string\\amd64\\strncpy.asm:46",
"fuzz!check D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:21",
"fuzz!from_file D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:67",
"<corrupt frame(s)>"
],
"minimized_stack_sha256": "8c0026819742a73973b587fd9e18545b1fd2770ebd65b9141f24bcc6c4e47b9c",
"minimized_stack_function_names": [
"fuzz!strncpy",
"fuzz!check",
"fuzz!from_file"
],
"minimized_stack_function_names_sha256": "58cd174f108dcd9cf568209a818dcae72d4fb7b0b85037598e26c214f3c44fce",
"task_id": "00000000-0000-0000-0000-000000000000",
"job_id": "00000000-0000-0000-0000-000000000000"
}
} New output: {
"crash_report": {
"input_sha256": "8abb9b1b07f17b5442c5d71b38eaf599ddd37fa38a3062c709a7e68412e57922",
"executable": "C:\\Users\\USERNAME\\projects\\test-artifacts\\windows-trivial-crash\\fuzz.exe",
"crash_type": "WriteAccessViolation",
"crash_site": "fuzz!strncpy minkernel\\crts\\ucrt\\src\\appcrt\\string\\amd64\\strncpy.asm:46",
"call_stack": [
"fuzz!strncpy minkernel\\crts\\ucrt\\src\\appcrt\\string\\amd64\\strncpy.asm:46",
"fuzz!check D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:21",
"fuzz!from_file D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:67",
"<corrupt frame(s)>"
],
"call_stack_sha256": "8c0026819742a73973b587fd9e18545b1fd2770ebd65b9141f24bcc6c4e47b9c",
"minimized_stack": [
"fuzz!check D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:21",
"fuzz!from_file D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:67",
"<corrupt frame(s)>"
],
"minimized_stack_sha256": "bc7b98cd717cc6a77450c7456d6f3e4a0fb7af2c3f80f8af6c6ea0ae4eb23784",
"minimized_stack_function_names": [
"check",
"from_file"
],
"minimized_stack_function_names_sha256": "a6577cb7f0b98e9eb955baedc8ed6d2192852f1aa2acb562985c853748a9f664",
"task_id": "00000000-0000-0000-0000-000000000000",
"job_id": "00000000-0000-0000-0000-000000000000"
}
} |
lzybkr
reviewed
Mar 23, 2021
ranweiler
reviewed
Mar 23, 2021
…hub.com/bmc-msft/onefuzz into include-symbol-module-names-stack-frame
ranweiler
reviewed
Mar 23, 2021
ranweiler
suggested changes
Mar 24, 2021
ranweiler
approved these changes
Mar 24, 2021
…hub.com/bmc-msft/onefuzz into include-symbol-module-names-stack-frame
Note, with the above changes, the output now looks like: {
"crash_report": {
"input_sha256": "24c3bb3be2e50c36320b9e737f81438e0ec34835ce39def8bec9921b64ac17e8",
"executable": "C:\\Users\\USERNAME\\projects\\test-artifacts\\windows-trivial-crash\\fuzz.exe",
"crash_type": "WriteAccessViolation",
"crash_site": "fuzz!strncpy+0x30 minkernel\\crts\\ucrt\\src\\appcrt\\string\\amd64\\strncpy.asm:46",
"call_stack": [
"fuzz!strncpy+0x30 minkernel\\crts\\ucrt\\src\\appcrt\\string\\amd64\\strncpy.asm:46",
"fuzz!check+0x1d D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:21",
"fuzz!from_file+0xa7 D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:67",
"<corrupt frame(s)>"
],
"call_stack_sha256": "da4ee7a170c47a7d34d92bda06d030e84060120396f26e8f938538e2dae9ceba",
"minimized_stack": [
"fuzz!check+0x1d D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:21",
"fuzz!from_file+0xa7 D:\\a\\onefuzz\\onefuzz\\src\\integration-tests\\trivial-crash\\fuzz.c:67",
"<corrupt frame(s)>"
],
"minimized_stack_sha256": "9d706a2aadca7cb39d81b01a0bab178c17792c83baa2a085baa2bfe167e5711e",
"minimized_stack_function_names": [
"check",
"from_file"
],
"minimized_stack_function_names_sha256": "a6577cb7f0b98e9eb955baedc8ed6d2192852f1aa2acb562985c853748a9f664",
"task_id": "00000000-0000-0000-0000-000000000000",
"job_id": "00000000-0000-0000-0000-000000000000"
}
} |
lzybkr
approved these changes
Mar 24, 2021
Hello @bmc-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
locked as resolved and limited conversation to collaborators
Apr 24, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the module_info and symbol name from debugger in the StackFrame. This enables the stack minimization function work on function names.