This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
embed coverage debugger scripts #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranweiler
approved these changes
Apr 9, 2021
| let (script_path, _temp_dir) = match env::var("ONEFUZZ_TOOLS") { | ||
| Ok(tools_dir) => { | ||
| let script_path = PathBuf::from(tools_dir); | ||
| if cfg!(target_os = "linux") { |
There was a problem hiding this comment.
It might be easier to track the logic if these branch cases were broken out into #[cfg(target_os = "<os>")]-annotated helper functions.
|
Hello @bmc-msft! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 18 hours, a condition that will be fulfilled in about 9 hours 22 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR embeds the coverage debugger scripts in the binaries, which streamlines the redistribution. Users can specify ONEFUZZ_TOOLS to specify a path to the scripts using existing behaviors.