This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Try to use Sancov tables when recording Windows coverage #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranweiler
changed the title
ranweiler
commented
May 2, 2021
| use pdb::{AddressMap, DataSymbol, FallibleIterator, Rva, ProcedureSymbol, Source, SymbolData, PDB}; | ||
|
|
||
| /// Basic block offset provider for uninstrumented PE modules. | ||
| pub struct PeBasicBlockProvider {} |
There was a problem hiding this comment.
In a future PR, we will revisit and move the PE process_ code into this type.
ranweiler
commented
May 2, 2021
bmc-msft
reviewed
May 3, 2021
|
This PR needs #847 merged to fix the build. |
bmc-msft
reviewed
May 3, 2021
bmc-msft
approved these changes
May 4, 2021
bmc-msft
approved these changes
May 4, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #842, #843, merge after.