Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

fix deployment using client_id #898

Merged
merged 1 commit into from
May 17, 2021

Conversation

bmc-msft
Copy link
Contributor

Fix issue in client creation from #872

@bmc-msft
Copy link
Contributor Author

In the aforementioned PR, Application.client_id isn't available.

It causes the exception:

INFO:deploy:checking if RBAC already exists
INFO:deploy:creating Application registration
INFO:deploy:creating service principal
Traceback (most recent call last):
  File "deploy.py", line 1082, in <module>
    main()
  File "deploy.py", line 1076, in main
    state[1](client)
  File "deploy.py", line 441, in setup_rbac
    "client_id": onefuzz_cli_app.client_id,
AttributeError: 'Application' object has no attribute 'client_id'

bmc-msft pushed a commit to bmc-msft/onefuzz that referenced this pull request May 17, 2021
@bmc-msft bmc-msft mentioned this pull request May 17, 2021
@bmc-msft bmc-msft merged commit 43440f3 into microsoft:main May 17, 2021
@bmc-msft bmc-msft deleted the fix-deploy-client-id branch May 17, 2021 15:53
@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants