This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
simplify long-life proxy cleanup #904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @nharper285 |
ghost
pushed a commit
that referenced
this pull request
May 22, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #839 , I hit a race condition where I created proxy session while the proxy was being shut down.
This PR addresses this race condition by
Additionally, this works addresses another issue I had not seen during the review of #839 but noticed upon handling the above issue. Currently, an up-to-date proxy is always maintained for any region a proxy has been created. If the worker VMs all move from eastus to eastus2, we don't need to continue to manage proxies in eastus.
This PR also includes EventProxyStateUpdated, which adds in debugging this aforementioned issue.
This PR also changes the VM names for proxies to be
proxy-<base58(proxy_id)>to handle the automatic disk name generation limits. Otherwise, disk names are truncated from the VM names and never get deleted.