This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
explain key=value argument parsing failures #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranweiler
approved these changes
May 21, 2021
ghost
pushed a commit
that referenced
this pull request
May 24, 2021
Catch argparse argument type errors and display them in a simplified fashion. As an example, this is how the output is rendered. ``` ❯ onefuzz template libfuzzer basic --target_env ASAN_OPTIONS=allocator_may_return_null=1 a a a linux unable to parse arguments: unable to parse value as a key=value pair: 'a' ❯ ``` Note, this builds upon #910.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As demonstrated in #906, failures in parsing key-value options is not obvious. This explains the failure in a slightly less obtuse fashion.