Fix and improve PDB search #913

ranweiler · 2021-05-23T19:01:04Z

Fix a bug in PDB search where we treated the absence of the PE-specified file as a hard error
In the return type of find_pdb_path(), distinguish between "no file found" and a search error

src/agent/coverage/src/pdb.rs

src/agent/debugger/src/dbghelp.rs

src/agent/coverage/src/pdb.rs

ranweiler added 2 commits May 23, 2021 11:23

Do not err on permissible file absence

898b7d1

Distinguish search errors and absent files

538231c

ranweiler changed the title ~~Partial pdb find~~ Fix and improve PDB search May 23, 2021

ranweiler commented May 23, 2021

View reviewed changes

src/agent/coverage/src/pdb.rs Show resolved Hide resolved

ranweiler commented May 23, 2021

View reviewed changes

src/agent/debugger/src/dbghelp.rs Show resolved Hide resolved

ranweiler commented May 23, 2021

View reviewed changes

src/agent/coverage/src/pdb.rs Show resolved Hide resolved

ranweiler mentioned this pull request May 23, 2021

Implement fast coverage-specific breakpoints #912

Closed

Format

6c55328

bmc-msft approved these changes May 24, 2021

View reviewed changes

ranweiler merged commit 700e55c into microsoft:main May 24, 2021

ranweiler deleted the partial-pdb-find branch May 24, 2021 15:11

ghost locked as resolved and limited conversation to collaborators Jun 23, 2021

Provide feedback