This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
mark tasks that are stopped that never started with an error #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
changed the title
ranweiler
reviewed
May 26, 2021
| @@ -19,7 +19,7 @@ def main(mytimer: func.TimerRequest, dashboard: func.Out[str]) -> None: # noqa: | |||
| expired_tasks = Task.search_expired() | |||
| for task in expired_tasks: | |||
| logging.info("stopping expired task: %s", task.job_id) | |||
| task.stopping() | |||
| task.mark_stopping() | |||
There was a problem hiding this comment.
How does this change relate to the other? Is it required?
There was a problem hiding this comment.
It is required, such that instead of calling the state handler directly, it does all of the other related stuff.
State handling is something we could use another refactor on, but that's out of scope for fixing this issue.
ranweiler
approved these changes
May 26, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934