This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
fix SyncedDir.remote_url issue with relative paths #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Url::from_file_path does not support creating `Url` with a relative path. This change converts relative paths to canonicalized absolute paths based on CWD.
chkeita
approved these changes
Jun 16, 2021
ranweiler
approved these changes
Jun 16, 2021
ranweiler
approved these changes
Jun 16, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Url::from_file_path does not support creating
Urlwith a relativepath. This change converts relative paths to canonicalized absolute
paths based on CWD.