Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] WebGPU and WASM Backends Unavailable within Service Worker #20876

Open
ggaabe opened this issue May 30, 2024 · 56 comments · Fixed by #20898
Open

[Web] WebGPU and WASM Backends Unavailable within Service Worker #20876

ggaabe opened this issue May 30, 2024 · 56 comments · Fixed by #20898
Assignees
Labels
ep:WebGPU ort-web webgpu provider platform:web issues related to ONNX Runtime web; typically submitted using template

Comments

@ggaabe
Copy link

ggaabe commented May 30, 2024

Describe the issue

I'm running into issues trying to use the WebGPU or WASM backends inside of a ServiceWorker (on a chrome extension). More specifically, I'm attempting to use Phi-3 with transformers.js v3

Every time I attempt this, I get the following error:

Uncaught (in promise) Error: no available backend found. ERR: [webgpu] 
TypeError: import() is disallowed on ServiceWorkerGlobalScope by the HTML specification. 
See https://github.com/w3c/ServiceWorker/issues/1356.

This is originating in the InferenceSession class in js/common/lib/inference-session-impl.ts.

More specifically, it's happening in this method:
const [backend, optionsWithValidatedEPs] = await resolveBackendAndExecutionProviders(options);
where the implementation is in js/common/lib/backend-impl.ts and the tryResolveAndInitializeBackend fails to initialize any of the execution providers.

WebGPU is now supported in ServiceWorkers though; it is a recent change and it should be feasible. Here were the chrome release notes.

Additionally, here is an example browser extension from the mlc-ai/web-llm framework that implements WebGPU usage in service workers successfully:
https://github.com/mlc-ai/web-llm/tree/main/examples/chrome-extension-webgpu-service-worker

Here is some further discussion on this new support from Google itself:
https://groups.google.com/a/chromium.org/g/chromium-extensions/c/ZEcSLsjCw84/m/WkQa5LAHAQAJ

So technically I think it should be possible for this to be supported now? Unless I'm doing something else glaringly wrong. Is it possible to add support for this?

To reproduce

Download and set up the transformers.js extension example and put this into the background.js file:

// background.js - Handles requests from the UI, runs the model, then sends back a response

import {
  pipeline,
  env,
  AutoModelForCausalLM,
  AutoTokenizer,
  TextStreamer,
  StoppingCriteria,
} from "@xenova/transformers";

// Skip initial check for local models, since we are not loading any local models.
env.allowLocalModels = false;

// Due to a bug in onnxruntime-web, we must disable multithreading for now.
// See https://github.com/microsoft/onnxruntime/issues/14445 for more information.
env.backends.onnx.wasm.numThreads = 1;

class CallbackTextStreamer extends TextStreamer {
  constructor(tokenizer, cb) {
    super(tokenizer, {
      skip_prompt: true,
      skip_special_tokens: true,
    });
    this.cb = cb;
  }

  on_finalized_text(text) {
    this.cb(text);
  }
}

class InterruptableStoppingCriteria extends StoppingCriteria {
  constructor() {
    super();
    this.interrupted = false;
  }

  interrupt() {
    this.interrupted = true;
  }

  reset() {
    this.interrupted = false;
  }

  _call(input_ids, scores) {
    return new Array(input_ids.length).fill(this.interrupted);
  }
}

const stopping_criteria = new InterruptableStoppingCriteria();

async function hasFp16() {
  try {
    const adapter = await navigator.gpu.requestAdapter();
    return adapter.features.has("shader-f16");
  } catch (e) {
    return false;
  }
}

class PipelineSingleton {
  static task = "feature-extraction";
  static model_id = "Xenova/Phi-3-mini-4k-instruct_fp16";
  static model = null;
  static instance = null;

  static async getInstance(progress_callback = null) {
    this.model_id ??= (await hasFp16())
      ? "Xenova/Phi-3-mini-4k-instruct_fp16"
      : "Xenova/Phi-3-mini-4k-instruct";

    this.tokenizer ??= AutoTokenizer.from_pretrained(this.model_id, {
      legacy: true,
      progress_callback,
    });

    this.model ??= AutoModelForCausalLM.from_pretrained(this.model_id, {
      dtype: "q4",
      device: "webgpu",
      use_external_data_format: true,
      progress_callback,
    });

    return Promise.all([this.tokenizer, this.model]);
  }
}

// Create generic classify function, which will be reused for the different types of events.
const classify = async (text) => {
  // Get the pipeline instance. This will load and build the model when run for the first time.
  const [tokenizer, model] = await PipelineSingleton.getInstance((data) => {
    // You can track the progress of the pipeline creation here.
    // e.g., you can send `data` back to the UI to indicate a progress bar
    console.log("progress", data);
    // data logs as this:
    /**
     * 
     * {
    "status": "progress",
    "name": "Xenova/Phi-3-mini-4k-instruct_fp16",
    "file": "onnx/model_q4.onnx",
    "progress": 99.80381792394503,
    "loaded": 836435968,
    "total": 838080131
  }

  when complete, last status will be 'done'
     */
  });
  /////////////
  const inputs = tokenizer.apply_chat_template(text, {
    add_generation_prompt: true,
    return_dict: true,
  });

  let startTime;
  let numTokens = 0;
  const cb = (output) => {
    startTime ??= performance.now();

    let tps;
    if (numTokens++ > 0) {
      tps = (numTokens / (performance.now() - startTime)) * 1000;
    }
    self.postMessage({
      status: "update",
      output,
      tps,
      numTokens,
    });
  };

  const streamer = new CallbackTextStreamer(tokenizer, cb);

  // Tell the main thread we are starting
  self.postMessage({ status: "start" });

  const outputs = await model.generate({
    ...inputs,
    max_new_tokens: 512,
    streamer,
    stopping_criteria,
  });
  const outputText = tokenizer.batch_decode(outputs, {
    skip_special_tokens: false,
  });

  // Send the output back to the main thread
  self.postMessage({
    status: "complete",
    output: outputText,
  });
  ///////////////

  // Actually run the model on the input text
  // let result = await model(text);
  // return result;
};

////////////////////// 1. Context Menus //////////////////////
//
// Add a listener to create the initial context menu items,
// context menu items only need to be created at runtime.onInstalled
chrome.runtime.onInstalled.addListener(function () {
  // Register a context menu item that will only show up for selection text.
  chrome.contextMenus.create({
    id: "classify-selection",
    title: 'Classify "%s"',
    contexts: ["selection"],
  });
});

// Perform inference when the user clicks a context menu
chrome.contextMenus.onClicked.addListener(async (info, tab) => {
  // Ignore context menu clicks that are not for classifications (or when there is no input)
  if (info.menuItemId !== "classify-selection" || !info.selectionText) return;

  // Perform classification on the selected text
  let result = await classify(info.selectionText);

  // Do something with the result
  chrome.scripting.executeScript({
    target: { tabId: tab.id }, // Run in the tab that the user clicked in
    args: [result], // The arguments to pass to the function
    function: (result) => {
      // The function to run
      // NOTE: This function is run in the context of the web page, meaning that `document` is available.
      console.log("result", result);
      console.log("document", document);
    },
  });
});
//////////////////////////////////////////////////////////////

////////////////////// 2. Message Events /////////////////////
//
// Listen for messages from the UI, process it, and send the result back.
chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
  console.log("sender", sender);
  if (message.action !== "classify") return; // Ignore messages that are not meant for classification.

  // Run model prediction asynchronously
  (async function () {
    // Perform classification
    let result = await classify(message.text);

    // Send response back to UI
    sendResponse(result);
  })();

  // return true to indicate we will send a response asynchronously
  // see https://stackoverflow.com/a/46628145 for more information
  return true;
});

Urgency

this would help enable a new ecosystem to build up around locally intelligent browser extensions and tooling.

it's urgent for me because it would be fun to build and I want to build it and it would be fun to be building it rather than not be building it.

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

1.19.0-dev.20240509-69cfcba38a

Execution Provider

'webgpu' (WebGPU)

@ggaabe ggaabe added the platform:web issues related to ONNX Runtime web; typically submitted using template label May 30, 2024
@fs-eire
Copy link
Contributor

fs-eire commented May 31, 2024

Than you for reporting this issue. I will try to figure out how to fix this problem.

@fs-eire fs-eire self-assigned this May 31, 2024
@fs-eire
Copy link
Contributor

fs-eire commented Jun 2, 2024

So it turns out to be that dynamic import (ie. import()) and top-level await is not supported in current service worker. I was not expecting that import() is banned in SW.

Currently, the WebAssembly factory (wasm-factory.ts) uses dynamic import to load the JS glue. This does not work in service worker. A few potential solutions are also not available:

  • Modifying it to import statement: won't work, because the JS glue includes top-level await.
  • Using importScripts: won't work, because the JS glue is ESM
  • Using eval: won't work; same to importScripts

I am now trying to make a JS bundle that does not use dynamic import for usage of service worker specifically. Still working on it

@ggaabe
Copy link
Author

ggaabe commented Jun 2, 2024

Thanks, I appreciate your efforts around this. It does seem like some special-case bundle will need to be built after all; you might need iife or umd for the bundler output format

@fs-eire
Copy link
Contributor

fs-eire commented Jun 2, 2024

Thanks, I appreciate your efforts around this. It does seem like some special-case bundle will need to be built after all; you might need iife or umd for the bundler output format

I have considered this option. However, Emscripten does not offer an option to output both UMD(IIFE+CJS) & ESM for JS glue (emscripten-core/emscripten#21899). I have to choose either. I choose the ES6 format output for the JS glue, because of a couple of problems when import UMD from ESM, and import() is a standard way to import ESM from both ESM and UMD. ( Until I know its not working in service worker by this issue)

I found a way to make ORT web working, - yes this need the build script to do some special handling. And this will only work for ESM, because the JS glue is ESM and it seems no way to import ESM from UMD in service worker.

fs-eire added a commit that referenced this issue Jun 3, 2024
### Description
<!-- Describe your changes. -->

This PR allows to build ORT web to `ort{.all|.webgpu}.bundle.min.mjs`,
which does not have any dynamic import. This makes it possible to use
ort web via static import in service worker.

Fixes #20876
@fs-eire fs-eire reopened this Jun 3, 2024
@fs-eire
Copy link
Contributor

fs-eire commented Jun 5, 2024

@ggaabe Could you please help to try import * as ort from “./ort.webgpu.bundle.min.js” from version 1.19.0-dev.20240604-3dd6fcc089 ?

@ggaabe
Copy link
Author

ggaabe commented Jun 6, 2024

@fs-eire my project is dependent on transformersjs, which imports onnxruntime webgpu backend like this here:

https://github.com/xenova/transformers.js/blob/v3/src/backends/onnx.js#L24

Is this the right usage? In my project I've added this to my package.json to resolve onnx-runtime to this new version though the issue is still occurring:

  "overrides": {
    "onnxruntime-web": "1.19.0-dev.20240604-3dd6fcc089"
  }

@ggaabe
Copy link
Author

ggaabe commented Jun 6, 2024

Maybe also important: The same error is still occurring in same spot in inference session in the onnx package and not from transformersjs. Do I need to add a resolver for onnxruntime-common as well?

@fs-eire
Copy link
Contributor

fs-eire commented Jun 10, 2024

#20991 makes default ESM import to use non-dynamic-import and hope this change may fix this problem. PR is still in progress

@ggaabe
Copy link
Author

ggaabe commented Jun 12, 2024

Hi @fs-eire, is the newly-merged fix in a released build I can try?

@fs-eire
Copy link
Contributor

fs-eire commented Jun 13, 2024

Please try 1.19.0-dev.20240612-94aa21c3dd

@sophies927 sophies927 added the ep:WebGPU ort-web webgpu provider label Jun 13, 2024
@ggaabe
Copy link
Author

ggaabe commented Jun 13, 2024

@fs-eire EDIT: Nvm the comment I just deleted, that error was because I didn't set the webpack target to webworker.

However, I'm getting a new error now (progress!):

Error: no available backend found. ERR: [webgpu] RuntimeError: null function or function signature mismatch

@ggaabe
Copy link
Author

ggaabe commented Jun 13, 2024

Update: Found the error is happening in here:

if (!isInitializing) {
backendInfo.initPromise = backendInfo.backend.init(backendName);
}
await backendInfo.initPromise;

For some reason the webgpu backend.init promise is rejecting due to the null function or function signature mismatch error. This is much further along than we were before though.

@fs-eire
Copy link
Contributor

fs-eire commented Jun 14, 2024

Update: Found the error is happening in here:

if (!isInitializing) {
backendInfo.initPromise = backendInfo.backend.init(backendName);
}
await backendInfo.initPromise;

For some reason the webgpu backend.init promise is rejecting due to the null function or function signature mismatch error. This is much further along than we were before though.

Could you share me the reproduce steps?

@ggaabe
Copy link
Author

ggaabe commented Jun 14, 2024

@fs-eire You'll need to run the webGPU setup in a chrome extension.

  1. You can use my code I just published here: https://github.com/ggaabe/extension
  2. run npm install
  3. run npm run build
  4. open the chrome manage extensions
Screenshot 2024-06-14 at 9 37 14 AM
  1. load unpacked
Screenshot 2024-06-14 at 9 37 52 AM
  1. select the build folder from the repo.
  2. open the AI WebGPU Extension extension
  3. type some text in the text input. it will load Phi-3 mini and after finishing loading this error will occur
  4. if you view the extension in the extension in the extension manager and select the "Inspect views
    service worker" link before opening the extension it will bring up an inspection window to view the errors as they occur. A little "errors" bubble link also shows up here after they occur.
Screenshot 2024-06-14 at 9 40 48 AM
  1. You will need to click the "Refresh" button on the extension in the extension manager to rerun the error because it does not attempt reloading the model after the first attempt until another refresh

@fs-eire
Copy link
Contributor

fs-eire commented Jun 18, 2024

@ggaabe I did some debug on my box and made some fixes -

  1. Changes to ONNXRuntime Web:

    [js/web] skip default locateFile() when dynamic import is disabled #21073 is created to make sure the web assembly file can be loaded correctly when env.wasm.wasmPaths is not specified.

  2. Changes to https://github.com/ggaabe/extension

    fix ORT wasm loading ggaabe/extension#1 need to be made to the extension example, to make it load the model correctly. Please note:

    • The onnxruntime-web version need to be updated to consume changes from (1) (after it get merged and published for dev channel)
    • There are still errors in background.js, which looks like incorrect params passed to tokenizer.apply_chat_template(). However, the WebAssembly is initialized and the model loaded successfully.
  3. Other issues:

@ggaabe
Copy link
Author

ggaabe commented Jun 18, 2024

Awesome, thank you for your thoroughness in explaining this and tackling this head on. Is there a dev channel version I can test out?

@fs-eire
Copy link
Contributor

fs-eire commented Jun 18, 2024

Not yet. Will update here once it is ready.

@ggaabe
Copy link
Author

ggaabe commented Jun 23, 2024

sorry to bug; is there any dev build number? wasn't sure how often a release runs

@fs-eire
Copy link
Contributor

fs-eire commented Jun 23, 2024

sorry to bug; is there any dev build number? wasn't sure how often a release runs

Please try 1.19.0-dev.20240621-69d522f4e9

@ggaabe
Copy link
Author

ggaabe commented Jun 23, 2024

@fs-eire I'm getting one new error:

ort.webgpu.bundle.min.mjs:6 Uncaught (in promise) Error: The data is not on CPU. Use `getData()` to download GPU data to CPU, or use `texture` or `gpuBuffer` property to access the GPU data directly.
    at get data (ort.webgpu.bundle.min.mjs:6:13062)
    at get data (tensor.js:62:1)

I pushed the code changes to my repo and fixed the call to the tokenizer. To reproduce, just type 1 letter in the chrome extension’s text input and wait

@nickl1234567
Copy link

Hey, I also need this. I am struggling with importing this version. So far I have been importing ONNX using
import * as ort from "https://cdn.jsdelivr.net/npm/onnxruntime-web/dist/esm/ort.webgpu.min.js".
However, when I change to import * as ort from "https://cdn.jsdelivr.net/npm/onnxruntime-web@1.19.0-dev.20240621-69d522f4e9/dist/esm/ort.webgpu.min.js" it seems not to have an .../esm/ folder. Do you know why that is and how to import it then?

@fs-eire
Copy link
Contributor

fs-eire commented Jun 24, 2024

Hey, I also need this. I am struggling with importing this version. So far I have been importing ONNX using import * as ort from "https://cdn.jsdelivr.net/npm/onnxruntime-web/dist/esm/ort.webgpu.min.js". However, when I change to import * as ort from "https://cdn.jsdelivr.net/npm/onnxruntime-web@1.19.0-dev.20240621-69d522f4e9/dist/esm/ort.webgpu.min.js" it seems not to have an .../esm/ folder. Do you know why that is and how to import it then?

just replace .../esm/ort.webgpu.min.js to .../ort.webgpu.min.mjs should work. If you are also using service worker, use ort.webgpu.bundle.min.mjs instead of ort.webgpu.min.mjs.

@fs-eire
Copy link
Contributor

fs-eire commented Jul 15, 2024

@kyr0 thank you a lot for your willing to help. I am currently in vacation but I will pick up this thread when I am back by end of this month.

@kyr0
Copy link

kyr0 commented Jul 18, 2024

@fs-eire Oh, I didn't mean to disturb you on vacation. Please enjoy, relax and have a lot of fun!

@asadm
Copy link

asadm commented Jul 20, 2024

@kyr0 do you by any chance have a fork that I can try with the custom env.wasm.instantiateWasm addition?

I would like to try your workaround since I am stuck in a similar spot (.wasm needs to be imported in userland code)

@kyr0
Copy link

kyr0 commented Jul 20, 2024

@asadm Well, I do have a solution for you to PoC if it would work, but I don't have a fork/PR yet. It's a bit messy, but I'll explain. If your code or a library that uses onnxruntime-web is importing the library, the module resolution algorithm will discover node_modules/onnxruntime-web/package.json and check for the exports defined in order to decide on which actual file to import. Your code, or the library code that your code is using, may have an import statement like this:

import { ... } from "onnxruntime-web/webgpu"

I decided, just to try, to simply change the code of onnxruntime-web on the fly. But the library only exports minified code by default. So I changed it's package.json exports to point to the non-minified code files instead:

{
    ".": {
      "node": {
        "import": "./dist/ort.mjs",
        "require": "./dist/ort.js"
      },
      "import": "./dist/ort.mjs",
      "require": "./dist/ort.js",
      "types": "./types.d.ts"
    },
    "./all": {
      "node": null,
      "import": "./dist/ort.all.bundle.min.mjs",
      "require": "./dist/ort.all.min.js",
      "types": "./types.d.ts"
    },
    "./wasm": {
      "node": null,
      "import": "./dist/ort.wasm.mjs",
      "require": "./dist/ort.wasm.js",
      "types": "./types.d.ts"
    },
    "./webgl": {
      "node": null,
      "import": "./dist/ort.webgl.min.mjs",
      "require": "./dist/ort.webgl.min.js",
      "types": "./types.d.ts"
    },
    "./webgpu": {
      "node": null,
      "import": "./dist/ort.webgpu.mjs",
      "require": "./dist/ort.webgpu.js",
      "types": "./types.d.ts"
    },
    "./training": {
      "node": null,
      "import": "./dist/ort.training.wasm.min.mjs",
      "require": "./dist/ort.training.wasm.min.js",
      "types": "./types.d.ts"
    }
  },

If you do that change in your local filesystem in your project, your build process will now point to those files, no matter what your build system looks like.

The next thing was to make onnxruntime-web/webgpu use my function if it is defined on env. There is 1 LoC where the call happens and it can access env in that scope. So I changed that code locally. Depending on what your code or the library you are using, is importing from onnxruntime-web, it might be one of those files. Or you change all of them, just to make sure.
node_modules/onnxruntime-web/dist/ort.mjs (line 24244), or node_modules/onnxruntime-web/dist/ort.wasm.mjs (line 1763):
Please note that the webgpu backend has no WASM import logic.

BEFORE:
Bildschirmfoto 2024-07-20 um 17 44 26

AFTER:
Bildschirmfoto 2024-07-20 um 18 03 58

I automated this process in a little NPM postinstall script, as I didn't want to spend much time on figuring all the build processes of onnxruntime-web yet.

.replace(/importWasmModule\(/g, '(typeof env.importWasmModule === "function" ? env.importWasmModule : importWasmModule)(')

I know, I know. Hacky.. but pragmatic. You will loose your changes each time you re-install your dependencies.

But, after all, you can now simply assign the function to the env and it will be called:

// @ts-ignore
import getModule from "./node_modules/onnxruntime-web/dist/ort-wasm-simd-threaded.jsep";

// you may need to copy this file and the WASM file into a folder so that the loader can fetch() it well
./node_modules/onnxruntime-web/dist/ort-wasm-simd-threaded.wasm

// this is a working example in my project - it loads just fine now
  env.backends.onnx.importWasmModule = async (
    mjsPathOverride: string,
    wasmPrefixOverride: string,
    threading: boolean,
  ) => {
    console.log(
      "importWasmModule",
      mjsPathOverride,
      wasmPrefixOverride,
      threading,
    );

    return [
      undefined,
      async (moduleArgs = {}) => {
        console.log("moduleArgs", moduleArgs);
        return await getModule(moduleArgs);
      },
    ];
  };

My proposal would be, just to change this one line of code in this project to allow for optional Inversion of Control @fs-eire -- it could be documented with my example code. This would probably all issues regarding "user-land based WASM loading".

Okay, I made a PR for that: #21430

@asadm
Copy link

asadm commented Jul 20, 2024

@kyr0 that is amazing! I was also hacking around with unminified bundle (don't want to rebuild from source etc).

Thank you so much for detailed solution, can't wait to try this when I get home!

@kyr0
Copy link

kyr0 commented Jul 20, 2024

@asadm You're welcome. No worries, we'll get this to work just fine, also for you :) Here's an impression from my background worker with the monkey patch applied. It's working, even through the @xenova/transformers.js abstraction layer in between:

350204823-86f101f4-5213-4b5a-bc94-4c6bbcce047b

Might take a while though, until downstream projects will adopt the new version. But once the maintainers here deploy a new version including my PR, we will be able to just override the onnxruntime-web dependencies using package overrides

@kyr0
Copy link

kyr0 commented Jul 20, 2024

I forgot to mention that you need to also alter the emscripten-generated WASM loader code too, or import a different build. emscripten generates the pthread variant with this code in the WASM runtime loader:

if (isNode) isPthread = (await import('worker_threads')).workerData === 'em-pthread';

For my PR, I should probably figure out a way to instruct emscripten to not generate code for Node.js, aka build a second variant of the runtime for Workers that has Node support explicitly disabled. When the runtime is worker, the default implementation could import that one instead. In special cases where the custom loader would be implemented by users, they could also then fallback to this variant.

Why? As stated in this conversation earlier: Top-level await isn't supported in Worker environments.

Bildschirmfoto 2024-07-20 um 19 04 52

@kyr0
Copy link

kyr0 commented Jul 21, 2024

@asadm https://github.com/kyr0/easy-embeddings demonstrates the whole process; I automated the monkey-patching for the moment... https://github.com/kyr0/easy-embeddings/blob/main/scripts/setup-transformers.ts

@fs-eire
Copy link
Contributor

fs-eire commented Jul 28, 2024

I created #21534, which is a replacement of #21430:

  • exposing the instantiateWasm directly may be not a good idea because this requires user to understand details of how WebAssembly works. I think this is unnecessary. To fulfill the requirement, allowing user to set an ArrayBuffer of the .wasm file should be good enough.
  • the import() is disallowed ... error is already fixed after version 1.19.0-dev.20240621-69d522f4e9. (only work for ESM. UMD will not work)
  • with this fix in ort-web, a few things are no longer need:
    • hacks on package.json and bundle
    • the top-level await is already taking care of by the build script of ort-web.

fs-eire added a commit that referenced this issue Jul 29, 2024
### Description

This PR adds a new option `ort.env.wasm.wasmBinary`, which allows user
to set to a buffer containing preload .wasm file content.

This PR should resolve the problem from latest discussion in #20876.
@kyr0
Copy link

kyr0 commented Aug 1, 2024

@fs-eire Sounds fair, and thank you for your work on this. Is there a new dev release that contains #21534 and that I could use to test, maybe? I'd surely only use ESM, so there shouldn't be an issue with that.

@fs-eire
Copy link
Contributor

fs-eire commented Aug 6, 2024

1.19.0-dev.20240801-4b8f6dcbb6 includes the change.

@lucasgelfond
Copy link

To clarify, is the best way to go about running transformers.js with WebGPU for the onnxruntime to monkeypatch the package to make the necessary wasm stuff load in each service worker, a la @kyr0's easy-embeddings? (Having some issues with that workflow, see kyr0/easy-embeddings#1)

Has anyone had luck / have tips for just running the v3 branch of Transformers.js? Or, maybe more precisely — do we know how something like Segment Anything WebGPU, which Xenova has in an HF Space, is working? Seems like there's been some official solution here but I can't find it documented / implemented well.

@fs-eire
Copy link
Contributor

fs-eire commented Aug 9, 2024

To clarify, is the best way to go about running transformers.js with WebGPU for the onnxruntime to monkeypatch the package to make the necessary wasm stuff load in each service worker, a la @kyr0's easy-embeddings? (Having some issues with that workflow, see kyr0/easy-embeddings#1)

Has anyone had luck / have tips for just running the v3 branch of Transformers.js? Or, maybe more precisely — do we know how something like Segment Anything WebGPU, which Xenova has in an HF Space, is working? Seems like there's been some official solution here but I can't find it documented / implemented well.

I am working with Transformer.js to make v3 branch compatible with latest module system. This is one of the merged changes: xenova/transformers.js#864. You probably need to use some workaround for now, but (hopefully) eventually you should be able to use it out of box.

@kyr0
Copy link

kyr0 commented Aug 10, 2024

@lucasgelfond Now that the new updates from @fs-eire are in place, I'm probably able to streamline the workaround. I'll have a look soon, but as I'm on vacation right now, I cannot give an ETA, unfortunately.

@lucasgelfond
Copy link

Thank you @fs-eire and @kyr0 ! No huge rush on my end, ended up getting inference working on WebGPU just on vanilla onnxruntime, will share results in a bit!

@lucasgelfond
Copy link

lucasgelfond commented Aug 11, 2024

Has anyone tried getting these imports working in Vite/other bundlers? When I try the classic:

import * as ONNX_WEBGPU from 'onnxruntime/webgpu

(which works in create-react-app), Vite says:

Error:   Failed to scan for dependencies from entries:
  /Users/focus/Projects/---/webgpu-sam2/frontend/src/routes/+page.svelte

  ✘ [ERROR] Missing "./webgpu/index.js" specifier in "onnxruntime-web" package [plugin vite:dep-scan]

Anyways, I tried importing from url, a la

import { InferenceSession, Tensor as ONNX_TENSOR } from 'https://cdn.jsdelivr.net/npm/onnxruntime-web@1.20.0-dev.20240810-6ae7e02d34/dist/ort.webgpu.min.js';

which Vite also doesn't like

3:34:51 PM [vite] Error when evaluating SSR module /src/encoder.svelte: failed to import "https://cdn.jsdelivr.net/npm/onnxruntime-web@1.20.0-dev.20240810-6ae7e02d34/dist/ort.webgpu.min.js"
|- Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. 

I disabled SSR in Svelte but still seemingly no luck/change.

I tried manually downloading the files with CURL, where I got an error about the lack of source map, so, I also downloaded .min.js.map. When I run it now, this works, but I get back to the original error in the thread about unavailable backends:

Error: no available backend found. ERR: [webgpu] TypeError: Failed to fetch dynamically imported module: http://localhost:5173/src/ort-wasm-simd-threaded.jsep.mjs

I figured it might work to just import directly, so I also tried:

import * as ONNX_WEBGPU from 'onnxruntime-web/dist/ort.webgpu.min.mjs';

but then I got
4:07:38 PM [vite] Internal server error: Missing "./dist/ort.webgpu.min.mjs" specifier in "onnxruntime-web" package

Anyone have ideas of how to handle? Happy to add more verbose error messages for any of the stuff above.

@fs-eire
Copy link
Contributor

fs-eire commented Aug 12, 2024

Has anyone tried getting these imports working in Vite/other bundlers? When I try the classic:

import * as ONNX_WEBGPU from 'onnxruntime/webgpu

(which works in create-react-app), Vite says:

Error:   Failed to scan for dependencies from entries:
  /Users/focus/Projects/---/webgpu-sam2/frontend/src/routes/+page.svelte

  ✘ [ERROR] Missing "./webgpu/index.js" specifier in "onnxruntime-web" package [plugin vite:dep-scan]

Anyways, I tried importing from url, a la

import { InferenceSession, Tensor as ONNX_TENSOR } from 'https://cdn.jsdelivr.net/npm/onnxruntime-web@1.20.0-dev.20240810-6ae7e02d34/dist/ort.webgpu.min.js';

which Vite also doesn't like

3:34:51 PM [vite] Error when evaluating SSR module /src/encoder.svelte: failed to import "https://cdn.jsdelivr.net/npm/onnxruntime-web@1.20.0-dev.20240810-6ae7e02d34/dist/ort.webgpu.min.js"
|- Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. 

I disabled SSR in Svelte but still seemingly no luck/change.

I tried manually downloading the files with CURL, where I got an error about the lack of source map, so, I also downloaded .min.js.map. When I run it now, this works, but I get back to the original error in the thread about unavailable backends:

Error: no available backend found. ERR: [webgpu] TypeError: Failed to fetch dynamically imported module: http://localhost:5173/src/ort-wasm-simd-threaded.jsep.mjs

I figured it might work to just import directly, so I also tried:

import * as ONNX_WEBGPU from 'onnxruntime-web/dist/ort.webgpu.min.mjs';

but then I got 4:07:38 PM [vite] Internal server error: Missing "./dist/ort.webgpu.min.mjs" specifier in "onnxruntime-web" package

Anyone have ideas of how to handle? Happy to add more verbose error messages for any of the stuff above.

Could you share me a repo that I can reproduce the issue? I will take a look.

@lucasgelfond
Copy link

@fs-eire you are amazing! https://github.com/lucasgelfond/webgpu-sam2

I swapped over to Webpack (in the svelte-webpack directory) but the original Vite version is in there. No immediate rush because I solved temporarily with Webpack, but Webpack breaks some other imports so would be awesome to move back—thanks so much again!

@lucasgelfond
Copy link

lucasgelfond commented Aug 13, 2024

(Non-working Vite stuff is now in previous commits because I shipped this!)

If you want to play with it, SAM-2 working totally in WebGPU! Here's a live demo link and here's the source, thanks all for the help!

demo

@Eldow
Copy link

Eldow commented Sep 9, 2024

👋 Thank you @fs-eire ! I tried using 1.19.0-dev.20240801-4b8f6dcbb6 inside of a chrome mv3 extension and it worked right away with the webgpu backend, however I'm more interested in using the wasm backend for running a simple decision forest as it doesn't include jsep and makes the overall bundle 10MB lighter. I wondered if there were any plans to support it too in a near future ?

@fs-eire
Copy link
Contributor

fs-eire commented Sep 9, 2024

👋 Thank you @fs-eire ! I tried using 1.19.0-dev.20240801-4b8f6dcbb6 inside of a chrome mv3 extension and it worked right away with the webgpu backend, however I'm more interested in using the wasm backend for running a simple decision forest as it doesn't include jsep and makes the overall bundle 10MB lighter. I wondered if there were any plans to support it too in a near future ?

Doesn't it work if by just replacing import "onnxruntime-web/webgpu" to import "onnxruntime-web"?

@Eldow
Copy link

Eldow commented Sep 10, 2024

It works indeed 😵 I tried doing import "onnxruntime-web/wasm" at first and this one still returned ERR: [wasm] TypeError: import() is disallowed on ServiceWorkerGlobalScope by the HTML specification

@juliankolbe
Copy link

juliankolbe commented Sep 11, 2024

So im still having this issue in 1.19.2.

This is in the context of a chrome extension, mv3, webgpu works fine. However cpu/wasm (as far as i understand they are aliases) does not. Ive been through the code and to me looks like the dynamic import is always happening and cant be skipped.

This:

const [objectUrl, ortWasmFactory] = await importWasmModule(mjsPathOverride, wasmPrefixOverride, numThreads > 1);

Calling this:

return [needPreload ? url : undefined, await dynamicImportDefault<EmscriptenModuleFactory<OrtWasmModule>>(url)];

Seems to lead to this:

ERR: [cpu] TypeError: import() is disallowed on ServiceWorkerGlobalScope by the HTML specification

I realize the poster above me is running the same setup and has it working, but Im really not sure what to do differently.

Using code from the test file, ive tried replicating it like so, but this doesnt seem to work:

import ort from "onnxruntime-web";

const binaryURL = ONNX_WASM_CDN_URL + "ort-wasm-simd-threaded.wasm";
const response = await fetch(binaryURL)
const binary = await response.arrayBuffer();
ort.env.wasm.wasmBinary = binary;
ort.env.wasm.numThreads = 1;

const session = await ort.InferenceSession.create(modelPath, {
  executionProviders: ["cpu"],
});

@fs-eire
Copy link
Contributor

fs-eire commented Sep 11, 2024

So im still having this issue in 1.19.2.

This is in the context of a chrome extension, mv3, webgpu works fine. However cpu/wasm (as far as i understand they are aliases) does not. Ive been through the code and to me looks like the dynamic import is always happening and cant be skipped.

This:

const [objectUrl, ortWasmFactory] = await importWasmModule(mjsPathOverride, wasmPrefixOverride, numThreads > 1);

Calling this:

return [needPreload ? url : undefined, await dynamicImportDefault<EmscriptenModuleFactory<OrtWasmModule>>(url)];

Seems to lead to this:

ERR: [cpu] TypeError: import() is disallowed on ServiceWorkerGlobalScope by the HTML specification

I realize the poster above me is running the same setup and has it working, but Im really not sure what to do differently.

Using code from the test file, ive tried replicating it like so, but this doesnt seem to work:

import ort from "onnxruntime-web";

const binaryURL = ONNX_WASM_CDN_URL + "ort-wasm-simd-threaded.wasm";
const response = await fetch(binaryURL)
const binary = await response.arrayBuffer();
ort.env.wasm.wasmBinary = binary;
ort.env.wasm.numThreads = 1;

const session = await ort.InferenceSession.create(modelPath, {
  executionProviders: ["cpu"],
});

If you are using 1.19.2 and still ran into this error, it is probably because your bundler imports onnxruntime-web as UMD. please verify the following:

  • check the version is 1.19.2 in <your_project_root>/node_modules/onnxruntime-web/package.json
  • check if your bundler actually loads file <your_project_root>/node_modules/onnxruntime-web/dist/ort.bundle.min.mjs. You can backup this file, then put a few illegal characters inside and run your bundler to quickly check. if you bundler still builds, that means it's not picking this file.

@juliankolbe
Copy link

juliankolbe commented Sep 12, 2024

Thanks so much for your help! The bundler was indeed the issue, for anyone reading this: I was using vite 4 and it was prefering the browser field in the package.json which led to the wrong file. Switching to vite 5 solves that issue as you can change the order of fields, even though it will by default already prefer the exports field.

I have another issue now though: Now that the correct file has made it, I am getting this error:

Error: no available backend found. ERR: [cpu] ReferenceError: Worker is not defined

any ideas what that might be?

edit:
Is tha poissble reason that web workers are not available in the background script of a chrome extension? (webgpu works here)
maybe @Eldow can shed some light on this?

edit#2:
Issue solved it seems, so:
content script, popup, background => webgpu
content script, popup, => webgpu, cpu

web worker is not available in service workers which run through the background script, hence cpu does not work there

edit#3

should multithreading be possible in a chrome extension? ive got this crossOriginIsolated blocking it. In a webapp easy to solve with headers, but in a chrome extension tricky.

So yeah if anyone has successfully used cpu multithreading in a chrome extension, doesnt matter how, please let me know.

@fs-eire
Copy link
Contributor

fs-eire commented Sep 13, 2024

In my understanding, Worker is unavailable in service worker. I have no idea whether this is by design or not. However, if you don't use multi-thread (set ort.env.wasm.numThreads = 1;) and disable proxy (do not set ort.env.wasm.proxy), onnxruntime-web should not use Worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider platform:web issues related to ONNX Runtime web; typically submitted using template
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants