Update supported ops md for NNAPI/CoreML EP #12245

YUNQIUGUO · 2022-07-19T23:27:29Z

Description: Describe your changes.

As title.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.

Update documentation based on newly added operator support.

edgchen1 · 2022-07-20T18:26:32Z

tools/ci_build/github/android/nnapi_supported_ops.md

 |ai.onnx:DequantizeLinear|All quantization scales and zero points should be constant.|
 |ai.onnx:Div||
 |ai.onnx:Elu||
 |ai.onnx:Exp||
 |ai.onnx:Flatten||
 |ai.onnx:Floor||
+|ai.onnx:Gather|Input indices should be an initializer if not int32 type.|


edgchen1 · 2022-07-20T18:41:11Z

tools/ci_build/github/android/nnapi_supported_ops.md

@@ -43,6 +47,7 @@ Keep in sync with doco generated from /docs/execution-providers/NNAPI-ExecutionP
 |ai.onnx:Sub||
 |ai.onnx:Tanh||
 |ai.onnx:Transpose||
+|ai.onnx:Unsqueeze||


axes must be constant

edgchen1 · 2022-07-20T18:52:53Z

tools/ci_build/github/android/nnapi_supported_ops.md

@@ -27,7 +29,9 @@ Keep in sync with doco generated from /docs/execution-providers/NNAPI-ExecutionP
 |ai.onnx:Min||
 |ai.onnx:Mul||
 |ai.onnx:Neg||
+|ai.onnx:Pad|Only constant mode Pad is supported.|


also requires non-negative pad values and constant pad and constant_value

edgchen1 · 2022-07-20T18:58:38Z

tools/ci_build/github/apple/coreml_supported_ops.md

 |ai.onnx:Gemm|Input B should be constant.|
 |ai.onnx:GlobalAveragePool|Only 2D Pool is supported.|
 |ai.onnx:GlobalMaxPool|Only 2D Pool is supported.|
 |ai.onnx:MatMul|Input B should be constant.|
 |ai.onnx:MaxPool|Only 2D Pool is supported.|
+|ai.onnx:PRelu|Input slope should be a constant initializer.<br/>Input slope should either have shape [C, 1, 1] or have 1 element.|


Suggested change

|ai.onnx:PRelu|Input slope should be a constant initializer.<br/>Input slope should either have shape [C, 1, 1] or have 1 element.|

|ai.onnx:PRelu|Input slope should be constant.<br/>Input slope should either have shape [C, 1, 1] or have 1 element.|

edgchen1 · 2022-07-20T18:59:13Z

thanks for updating these!

YUNQIUGUO · 2022-07-20T19:02:33Z

thanks for updating these!

thanks for the review. missed a couple points. updated now!

tools/ci_build/github/android/nnapi_supported_ops.md

* update supported ops md * address pr comments * address pr comments * wording

* update package version * Prevent unbounded growth of command allocator memory (#12114) Prevent unbounded growth of command allocator memory * Update supported ops md for NNAPI/CoreML EP (#12245) * update supported ops md * address pr comments * address pr comments * wording * Change native folder name for java macos arm64 (#12335) * Bump async from 2.6.3 to 2.6.4 in /js/react_native/e2e (#11280) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [js/rn] upgrade dependencies for e2e test (#11863) * [js/rn] upgrade dependencies for e2e test * use JDK11 only for gradle * expand variable * [js/rn] upgrade package react-native@^0.69.1 (#12155) * [js/rn] upgrade package react-native@^0.69.1 * upgrade compile sdk to v31 * update ios version requirement * update pod path for onnxruntime-react-native * add missing build_java in Android testing stage. (#12187) add missing build_java in testing * Use specific Android NDK version in CI builds. (#12350) Current builds use a NDK version that happens to be on the build machine. The build machine environment may change in ways that are outside of our control. This change installs a specific version of NDK (the current LTS version 25.0.8775105) and uses it. * Remove preview keyword from DirectML pacakge (#12368) Remove preview keyword Co-authored-by: Sumit Agarwal <sumitagarwal@microsoft.com> * Scope CreateFileMapping2 to valid API partitions (#12374) * Fix TRT custom op issue (#12283) * Pass schema registry on CreateModel. * Fix ORT_MINIMAL_BUILD. * Fix build issue. * Manually add optimization flag for Android Release builds. (#12390) With recent versions of NDK (since 23), the `-O` optimization level compile flag is not being passed when building in the "Release" configuration. More details here: android/ndk#1740 Our "Release" Android builds have been built without the optimization flag since we upgraded from NDK 21. This change is a workaround to manually add `-O3` for "Release" Android builds. * resolve conflicts in tensorRT related changes * Enable support of multi-level nested control flow ops model for TRT EP (#12147) * Make multiple-level nested control flow op model work * find correct input index * find correct input index (cont.) * enable nested layer unit tests for TRT EP * add comment * add Scan op to current workaround support of control flow op Co-authored-by: Jeff Bloomfield <38966965+jeffbloo@users.noreply.github.com> Co-authored-by: Rachel Guo <35738743+YUNQIUGUO@users.noreply.github.com> Co-authored-by: Changming Sun <chasun@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yulong Wang <7679871+fs-eire@users.noreply.github.com> Co-authored-by: Yi Zhang <zhanyi@microsoft.com> Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com> Co-authored-by: sumitsays <sumitagarwal330@gmail.com> Co-authored-by: Sumit Agarwal <sumitagarwal@microsoft.com> Co-authored-by: Justin Stoecker <justoeck@microsoft.com> Co-authored-by: Yateng Hong <yatengh@microsoft.com> Co-authored-by: Chi Lo <54722500+chilo-ms@users.noreply.github.com>

update supported ops md

84d9c1c

YUNQIUGUO requested review from skottmckay and edgchen1 July 19, 2022 23:27

edgchen1 reviewed Jul 20, 2022

View reviewed changes

YUNQIUGUO added 2 commits July 20, 2022 12:00

address pr comments

5308675

address pr comments

5daa50f

edgchen1 previously approved these changes Jul 20, 2022

View reviewed changes

tools/ci_build/github/android/nnapi_supported_ops.md Outdated Show resolved Hide resolved

tools/ci_build/github/android/nnapi_supported_ops.md Outdated Show resolved Hide resolved

wording

0a724f4

YUNQIUGUO dismissed edgchen1’s stale review via 0a724f4 July 20, 2022 21:53

edgchen1 approved these changes Jul 20, 2022

View reviewed changes

YUNQIUGUO merged commit 4966185 into master Jul 21, 2022

YUNQIUGUO deleted the yguo/update-supported-ops-doc branch July 21, 2022 17:23

skottmckay added the release:1.12.1 label Aug 1, 2022

RandySheriffH pushed a commit that referenced this pull request Aug 2, 2022

Update supported ops md for NNAPI/CoreML EP (#12245)

c3c79eb

* update supported ops md * address pr comments * address pr comments * wording

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update supported ops md for NNAPI/CoreML EP #12245

Update supported ops md for NNAPI/CoreML EP #12245

YUNQIUGUO commented Jul 19, 2022

edgchen1 Jul 20, 2022

edgchen1 Jul 20, 2022

edgchen1 Jul 20, 2022 •

edited

Loading

edgchen1 Jul 20, 2022

edgchen1 commented Jul 20, 2022

YUNQIUGUO commented Jul 20, 2022

	\|ai.onnx:Gather\|Input indices should be an initializer if not int32 type.\|
	\|ai.onnx:Gather\|Input indices should be constant if not int32 type.\|

	\|ai.onnx:PRelu\|Input slope should be a constant initializer.<br/>Input slope should either have shape [C, 1, 1] or have 1 element.\|
	\|ai.onnx:PRelu\|Input slope should be constant.<br/>Input slope should either have shape [C, 1, 1] or have 1 element.\|

Update supported ops md for NNAPI/CoreML EP #12245

Update supported ops md for NNAPI/CoreML EP #12245

Conversation

YUNQIUGUO commented Jul 19, 2022

edgchen1 Jul 20, 2022

Choose a reason for hiding this comment

edgchen1 Jul 20, 2022

Choose a reason for hiding this comment

edgchen1 Jul 20, 2022 • edited Loading

Choose a reason for hiding this comment

edgchen1 Jul 20, 2022

Choose a reason for hiding this comment

edgchen1 commented Jul 20, 2022

YUNQIUGUO commented Jul 20, 2022

edgchen1 Jul 20, 2022 •

edited

Loading