Initial checkin of CumSum and Round as contrib ops for 1P model #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If these ops have been accepted into ONNX, it's better to update the onnx commit id and check these in as official ops. |
|
The onnx commit id has also been updated... just needs merging with master |
I'll close this PR, and instead add them as official ops (not contrib). Please review PR #1705 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This adds new operators CumSum and Round as contrib ops.
Motivation and Context
These operators are required for speech models. They are also part of opset 11, so will need to migrate to official list later on. However, since ORT is not opset-11 compliant yet, and customer requires these ops for speech synthesis model, the best location is in contrib ops.