Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade emsdk from 3.1.59 to 3.1.62 #21421

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Upgrade emsdk from 3.1.59 to 3.1.62 #21421

merged 8 commits into from
Aug 14, 2024

Conversation

satyajandhyala
Copy link
Contributor

@satyajandhyala satyajandhyala commented Jul 19, 2024 •
edited
Loading

Description

Upgrade EM SDK to 3.1.63.

Motivation and Context

The changes are required to clear wasm64 errors.

@satyajandhyala satyajandhyala changed the title Upgrade emsdk from 3.1.59 to 3.1.62 Upgrade emsdk from 3.1.59 to 3.1.63 Jul 19, 2024
@satyajandhyala satyajandhyala marked this pull request as ready for review July 19, 2024 21:02
@satyajandhyala satyajandhyala requested review from a team as code owners July 19, 2024 21:02
@satyajandhyala satyajandhyala requested a review from fs-eire July 19, 2024 21:02
snnn
snnn previously approved these changes Jul 20, 2024
View reviewed changes
@fs-eire
Copy link
Contributor

fs-eire commented Jul 20, 2024

Thank you for the update but please hold it a little bit as we observed a feature regression in 3.1.63.

See emscripten-core/emscripten#22165 (comment)

@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_upgrade_emsdk_from_3.1.59_to_3.1.62 branch from c0614da to 4f30b6c Compare July 22, 2024 21:47
@satyajandhyala
Copy link
Contributor Author

Thank you for the update but please hold it a little bit as we observed a feature regression in 3.1.63.

See emscripten-core/emscripten#22165 (comment)

Applied suggested fix.

snnn
snnn previously approved these changes Jul 23, 2024
View reviewed changes
@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_upgrade_emsdk_from_3.1.59_to_3.1.62 branch from 923568c to f6dd6ea Compare July 23, 2024 17:27
@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_upgrade_emsdk_from_3.1.59_to_3.1.62 branch from f6dd6ea to d634004 Compare July 23, 2024 22:02
@satyajandhyala satyajandhyala changed the title Upgrade emsdk from 3.1.59 to 3.1.63 Upgrade emsdk from 3.1.59 to 3.1.62 Jul 23, 2024
@satyajandhyala
Copy link
Contributor Author

Upgrade to 3.1.62 instead of 3.1.63

@fs-eire
Copy link
Contributor

fs-eire commented Jul 23, 2024

also file .gitmodules in root need to be updated.

fs-eire
fs-eire previously approved these changes Jul 23, 2024
View reviewed changes
snnn
snnn previously approved these changes Jul 24, 2024
View reviewed changes
@satyajandhyala satyajandhyala added the ep:WebGPU ort-web webgpu provider label Jul 30, 2024
@satyajandhyala satyajandhyala dismissed stale reviews from fs-eire and snnn via d66e7f5 July 30, 2024 18:05
@satyajandhyala satyajandhyala requested review from fs-eire and snnn August 14, 2024 06:46
@fs-eire fs-eire removed the request for review from snnn August 14, 2024 19:31
@satyajandhyala satyajandhyala requested a review from a team August 14, 2024 19:33
@satyajandhyala satyajandhyala merged commit 6d8de1f into main Aug 14, 2024
95 of 97 checks passed
@satyajandhyala satyajandhyala deleted the sajandhy/webgpu_upgrade_emsdk_from_3.1.59_to_3.1.62 branch August 14, 2024 19:38
guschmue added a commit that referenced this pull request Aug 21, 2024
@guschmue
Revert "Upgrade emsdk from 3.1.59 to 3.1.62 (#21421)"
1bcb775 
This reverts commit 6d8de1f.
@guschmue guschmue mentioned this pull request Aug 21, 2024
Merged
satyajandhyala added a commit that referenced this pull request Aug 21, 2024
@satyajandhyala
Revert "Upgrade emsdk from 3.1.59 to 3.1.62 (#21421)"
4a6a0aa 
This reverts commit 6d8de1f.
guschmue added a commit that referenced this pull request Aug 22, 2024
@guschmue
Revert "Upgrade emsdk from 3.1.59 to 3.1.62" (#21817)
ba7baae 
Reverts #21421

Users are seeing chrome memory grow to 16GB before it crashes:
#21810

Revert for now so we have time to debug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavsharma pranavsharma pranavsharma approved these changes

@fs-eire fs-eire fs-eire approved these changes

@baijumeswani baijumeswani baijumeswani approved these changes

@guschmue guschmue guschmue approved these changes

@snnn snnn snnn left review comments

Assignees

@fs-eire fs-eire

Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@satyajandhyala @fs-eire @snnn @pranavsharma @baijumeswani @guschmue