Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build configurations to webgpu EP #22047

Merged
merged 37 commits into from
Sep 25, 2024

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Sep 10, 2024

Description

list out for tracking.

fs-eire added a commit that referenced this pull request Sep 11, 2024
@fs-eire
Copy link
Contributor Author

fs-eire commented Sep 11, 2024

merged a few misc improvements and only list build configuration change.

@skottmckay skottmckay requested a review from a team as a code owner September 16, 2024 08:25
@skottmckay skottmckay requested review from a team as code owners September 23, 2024 22:40
@skottmckay
Copy link
Contributor

Sorry - I didn't realize this branch was in a PR and I just merged in origin/main.

@fs-eire do you want to update your branch with the latest origin/main to make the diffs reasonable again?

@fs-eire
Copy link
Contributor Author

fs-eire commented Sep 24, 2024

Sorry - I didn't realize this branch was in a PR and I just merged in origin/main.

@fs-eire do you want to update your branch with the latest origin/main to make the diffs reasonable again?

I did it just now. But seems the status of PR is not updating to remove those unrelated changes.

@snnn
Copy link
Member

snnn commented Sep 24, 2024

You need to close this one and open a new PR.

@fs-eire
Copy link
Contributor Author

fs-eire commented Sep 24, 2024

You need to close this one and open a new PR.

I tried to do that but in the change preview it still shows 140 files. Maybe need a git merge

@fs-eire
Copy link
Contributor Author

fs-eire commented Sep 24, 2024

You need to close this one and open a new PR.

I tried to do that but in the change preview it still shows 140 files. Maybe need a git merge

OK much better now.

@fs-eire fs-eire merged commit f02e85a into fs-eire/webgpu-ep Sep 25, 2024
40 of 41 checks passed
@fs-eire fs-eire deleted the skottmckay/MiscWebGPUUpdates branch September 25, 2024 23:53
@skottmckay skottmckay restored the skottmckay/MiscWebGPUUpdates branch September 27, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants