[Native-WebGPU] Add Concat #22225
Merged
[Native-WebGPU] Add Concat #22225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
reviewed
Sep 27, 2024
| @@ -101,6 +101,10 @@ class ShaderHelper final { | |||
| return *this; | |||
| } | |||
|
|
|||
| const std::vector<std::unique_ptr<ShaderVariableHelper>>& GetInputVars() { | |||
There was a problem hiding this comment.
The reason why I do not want to expose the input_vars_ directly, is because this getter exposed the internal implementation details and made the type as a part of public interface.
I would do it a little differently in concat.cc:
std::vector<const ShaderVariableHelper *> input_vars;
for (size_t i = 0; i < input_count_; ++i) {
input_vars.push_back(&shader.AddInput("input_" + std::to_string(i), ShaderUsage::UseUniform | ShaderUsage::UseIndicesTypeAlias));
}
fs-eire
reviewed
Sep 27, 2024
| Status Concat::ComputeInternal(ComputeContext& context) const { | ||
| auto input_count = context.InputCount(); | ||
| InlinedTensorsVector input_tensors; | ||
| input_tensors.reserve(input_count); |
There was a problem hiding this comment.
add a TODO to deal with input_count + 1 /* output_count */ > max_allowed_buffer_per_shader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Concat operator support
Motivation and Context
Required for WebGPU EP