Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetEpDynamicOptions and remove workload_type from run/session options #22282

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

l31g
Copy link
Contributor

@l31g l31g commented Oct 1, 2024

Description

Add SetEpDynamicOptions and Remove workload_type from run/session options.

Motivation and Context

Added SetEpDynamicOptions as a dynamic way of changing EP settings even in the middle of a Run
Using workload_type run/session options to set Efficient/Default mode for workloads does not cover all the scenarios and can lead to priority inversions. Working on a new API to support setting Efficient/Default mode for workloads.

Remove workload_type Run options
Remove workload_type Session options
@l31g
Copy link
Contributor Author

l31g commented Oct 1, 2024

@microsoft-github-policy-service agree company="Microsoft"

…t been compiled yet and needs review by experiences ORT devs
@l31g l31g changed the title Remove workload_type from run/session options Add SetEpDynamicOptions and remove workload_type from run/session options Oct 2, 2024
@jywu-msft
Copy link
Member

fix lintrunner issues https://github.com/microsoft/onnxruntime/actions/runs/11156136570/job/31242339769?pr=22282
i think there are some newlines it's detecting?

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline, Windows CPU CI Pipeline

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@pranavsharma pranavsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about language bindings? Do we need them for the upcoming release?

onnxruntime/core/session/inference_session.h Outdated Show resolved Hide resolved
onnxruntime/core/session/inference_session.cc Outdated Show resolved Hide resolved
onnxruntime/core/session/inference_session.cc Show resolved Hide resolved
onnxruntime/core/session/onnxruntime_c_api.cc Outdated Show resolved Hide resolved
@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@jywu-msft
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline

@jywu-msft
Copy link
Member

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@jywu-msft jywu-msft merged commit 1bc546a into microsoft:main Oct 10, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants