Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webgpu-native] Fix a few build errors on Linux #22286

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[webgpu-native] Fix a few build errors on Linux #22286

merged 1 commit into from
Oct 1, 2024

Conversation

snnn
Copy link
Member

@snnn snnn commented Oct 1, 2024

  1. On Linux path strings are not std::wstring. They should be std::string.
  2. "auto i =0" means i will be int. But sometimes we want to it to be size_t.

@snnn snnn requested a review from fs-eire October 1, 2024 18:10
@snnn snnn changed the title Fix a build error in webgpu native [webgpu-native] Fix a few build errors on Linux Oct 1, 2024
@fs-eire
Copy link
Contributor

fs-eire commented Oct 1, 2024

Linter failed. Is it because of EOL?

@fs-eire fs-eire merged commit d219bb7 into microsoft:fs-eire/webgpu-ep Oct 1, 2024
38 of 40 checks passed
@snnn
Copy link
Member Author

snnn commented Oct 1, 2024

Most likely.

@snnn snnn deleted the snnn/gpu1 branch October 1, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fs-eire fs-eire fs-eire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snnn @fs-eire