[CoreML ML Program] support acclerators selector #22383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
reviewed
Oct 10, 2024
| // Create an MLProgram. By default it will create a NeuralNetwork model. Requires Core ML 5 or later. | ||
| COREML_FLAG_CREATE_MLPROGRAM = 0x010, | ||
| COREML_FLAG_CREATE_MLPROGRAM = 0x100, |
There was a problem hiding this comment.
We shouldn't change any existing flag as that will break any current usage of the EP.
Could we maybe just add a new 'no ANE' flag if the problem we're trying to solve is that large data sizes run less efficiently if CoreML attempts to use the ANE?
There was a problem hiding this comment.
Yes, we could.
But the flag's value shouldn't be really matter given that we are using this enum variable.
Please Correct me if I am wrong.
wejoncy
force-pushed
the
jicwen/coremlgpu
branch
from
fbbd1c0
to
6209cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For no, CoreML only support run mlmodels on CPU/ALL, However, sometimes CPU_GPU would be faster a lot.
We support the option to select different hardware to boost performance in this PR.
Motivation and Context