update kernel memory type interface #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkerzhang
reviewed
Dec 20, 2018
| const MemTypeMap& MemoryType() const { | ||
| return output_memory_type_args_; | ||
| OrtMemType OutputMemoryType(size_t output_index) const { | ||
| auto it = output_memory_type_args_.find(output_index); |
Contributor
There was a problem hiding this comment.
this is not introduced by your PR, but why we use map to store the types, instead of vector.
Member
Author
There was a problem hiding this comment.
I guess in most case people only declare memory type for very few input/output, map seems more suitable.
|
|
||
| class KernelDefBuilder { | ||
| public: | ||
| explicit KernelDefBuilder(OrtMemType inputs_mem_type, OrtMemType outputs_mem_type) |
Contributor
There was a problem hiding this comment.
I would suggest to move this as an explicit setter method.
linkerzhang
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current kernel memory type interface can't support variadic inputs. Cheng the interface to query-based so we could have a customized default memory type.