Improves 2d tiled matmulnbits by repeating A, loads N times for each B load #23071
+30
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves on previous change Implement 2d tiled matmulnbits specialized for prefill by keeping B in shared memory and reloading just A N times.
This is based on the observation that loading B is more expensive than loading A, that is for a run of size 16 seq length [3072, 3072, 8192] this matrix multiplication takes 1.9ms. Removing loadA drops it to 1.8ms, removing loadB drops it to 1.44ms.
By sharing B across multiple A tiles, the cost to load B and dequantize is reduced N fold.