More intuitive ordering to the API functions #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanbyu
previously approved these changes
Dec 20, 2018
snnn
reviewed
Dec 20, 2018
| #endif | ||
| #define ORT_API_CALL _stdcall | ||
| #define ORT_MUST_USE_RESULT | ||
| #define TCHAR_T wchar_t |
Contributor
There was a problem hiding this comment.
Could you find a new name? TCHAR is not good. Because we compile our code in ANSI mode on Windows, TCHAR is char but here TCHAR_T is wchar_t.
Contributor
Author
There was a problem hiding this comment.
What do you suggest? I just wanted to avoid the #ifdef _WIN32
Contributor
Author
There was a problem hiding this comment.
Ok, I talked to you, we'll change it to ORTCHAR_T for now, then fix it to be TCHAR once we verify we an build in Unicode/multibyte properly on windows.
snnn
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macros/defines are still at the top but these will probably be moved to a separate file.
The functions are ordered by what you'd need to do first and next by category.