New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU EP] SoftMax Implementation #23538

Open

vraspar wants to merge 8 commits into main from vraspar/webgpu-softmax

+339 −26

Contributor

vraspar commented Jan 30, 2025 •

edited

Loading

Increase coverage for WebGPU Op

vraspar and others added 3 commits

January 20, 2025 17:26


          Add Softmax kernel and transpose utility function for WebGPU executio…

e7e3737

…n provider


          Refactor Softmax implementation for WebGPU

f9b61db


          Refactor Softmax and remove debug logs

87de607

vraspar commented

View reviewed changes

onnxruntime/core/providers/webgpu/shader_variable.h Outdated Show resolved Hide resolved

vraspar added the ep:WebGPU label

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

You can commit the suggested changes from lintrunner.

onnxruntime/core/providers/webgpu/shader_variable.h Outdated Show resolved Hide resolved


          fix linting error

2d8b47d

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

vraspar requested review from skottmckay and fs-eire

January 30, 2025 19:50

fs-eire reviewed

View reviewed changes

onnxruntime/test/providers/cpu/math/softmax_test.cc Outdated Show resolved Hide resolved

fs-eire reviewed

View reviewed changes

onnxruntime/core/providers/webgpu/tensor/transpose.cc Show resolved Hide resolved

fs-eire reviewed

View reviewed changes

onnxruntime/core/providers/webgpu/tensor/transpose.cc Outdated Show resolved Hide resolved

fs-eire reviewed

View reviewed changes

onnxruntime/core/providers/webgpu/math/softmax.cc Outdated Show resolved Hide resolved

fs-eire reviewed

View reviewed changes

onnxruntime/core/providers/webgpu/math/softmax.cc Outdated Show resolved Hide resolved

vraspar added 3 commits

February 3, 2025 14:25


          Refactor Softmax implementation for improved readability and consiste…

91f635c

…ncy in variable naming


          Revert changes made to shader_variable.h

5cff682


          Fix variable declaration in softmax

e6d8a09

yuslepukhin reviewed

View reviewed changes

onnxruntime/core/providers/webgpu/math/softmax.cc Outdated Show resolved Hide resolved

yuslepukhin reviewed

View reviewed changes

onnxruntime/core/providers/webgpu/math/softmax.cc Outdated Show resolved Hide resolved

yuslepukhin reviewed

View reviewed changes

onnxruntime/core/providers/webgpu/math/softmax.cc Outdated Show resolved Hide resolved

yuslepukhin reviewed

View reviewed changes

onnxruntime/core/providers/webgpu/tensor/transpose.cc Outdated Show resolved Hide resolved

yuslepukhin requested changes

View reviewed changes

Member

yuslepukhin left a comment

🕐


          Apply feedback: use more suitable data types

a2c7069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fs-eire fs-eire left review comments

github-actions[bot] github-actions[bot] left review comments

yuslepukhin yuslepukhin requested changes

skottmckay Awaiting requested review from skottmckay

Requested changes must be addressed to merge this pull request.

Labels