Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --use_openmp in build.sh #3657

Closed
wants to merge 1 commit into from

Conversation

fumihwh
Copy link
Contributor

@fumihwh fumihwh commented Apr 23, 2020

Remove --use_openmp in build.sh to fix build failed problem on Mac.
#3313

@fumihwh fumihwh requested a review from a team as a code owner April 23, 2020 15:41
@Craigacp
Copy link
Contributor

If you've got homebrew running on your Mac you can install libomp and then this patch should make it build - https://gist.github.com/Craigacp/66be36737e21df87eee4c0197e76862a.

@fumihwh
Copy link
Contributor Author

fumihwh commented Apr 24, 2020

If you've got homebrew running on your Mac you can install libomp and then this patch should make it build - https://gist.github.com/Craigacp/66be36737e21df87eee4c0197e76862a.

@Craigacp Thanks for reply.
As --use_openmp can be passed to build.sh as an argument, we should not put it into build.sh as default and can not be set to false.

@wschin
Copy link
Contributor

wschin commented Apr 24, 2020

openmp is an important part for computation. I feel if Mac build fails because of it, we need to fix Mac build instead of getting rid of a part of ONNXRuntime. Any comments?

@snnn
Copy link
Member

snnn commented Apr 24, 2020

It's not for removing openmp from our build pipelines. As far as I know, none of these are using this script. But maybe I'm wrong, please double check. Maybe there is a less common pipeline I don't know.

@yufenglee
Copy link
Member

yufenglee commented Apr 26, 2020

If you've got homebrew running on your Mac you can install libomp and then this patch should make it build - https://gist.github.com/Craigacp/66be36737e21df87eee4c0197e76862a.

@Craigacp Thanks for reply.
As --use_openmp can be passed to build.sh as an argument, we should not put it into build.sh as default and can not be set to false.

Yes, that's right. In addition, build.bat doesn't set use_openmp by default. It's really confusing.
@fumihwh, we have dock files using build.sh. Please update them by adding --use_openmp to keep their build options.

@snnn
Copy link
Member

snnn commented May 4, 2020

Hi @fumihwh, could you please update your branch with the latest master? I couldn't schedule the some CI builds for you.

@snnn snnn closed this May 25, 2020
@snnn
Copy link
Member

snnn commented May 25, 2020

Thank you! @fumihwh,

@fumihwh
Copy link
Contributor Author

fumihwh commented Jun 28, 2020

@snnn Sorry for the late reply. Glad to see the change is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants