-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove --use_openmp in build.sh #3657
Conversation
If you've got homebrew running on your Mac you can install |
@Craigacp Thanks for reply. |
openmp is an important part for computation. I feel if Mac build fails because of it, we need to fix Mac build instead of getting rid of a part of ONNXRuntime. Any comments? |
It's not for removing openmp from our build pipelines. As far as I know, none of these are using this script. But maybe I'm wrong, please double check. Maybe there is a less common pipeline I don't know. |
Yes, that's right. In addition, build.bat doesn't set use_openmp by default. It's really confusing. |
Hi @fumihwh, could you please update your branch with the latest master? I couldn't schedule the some CI builds for you. |
Thank you! @fumihwh, |
@snnn Sorry for the late reply. Glad to see the change is merged. |
Remove
--use_openmp
in build.sh to fix build failed problem on Mac.#3313