fix: informing about bad positional argument in node constructor #1984

[leshabirukov]

Patch, proposed in
#1984

[justinchuby]

Thanks for the proposal! I would consider creating the check outside of the IR. Here, a lingering None value as the last input is entirely valid.

[leshabirukov]

About None, - this part must allow None, if my understanding correct:

if self._inputs **and self._inputs[-1]** and not isinstance(self._inputs[-1], (Value)):

(actually, it allows 0.0, and that's bad, needs to change that)

if self._inputs and self._inputs[-1] is not None and not isinstance(self._inputs[-1], (Value)):

About moving check outside, will research, probably after 01.01 :)

[justinchuby]

I see, you are right. Although this check should still be moved outside for performance reasons. Feel free to propose something, or I can take a look when I get a chance.