Skip to content

Fix optimizer tests #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Fix optimizer tests #2217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e0139
Fix optimizer tests
justinchuby Apr 22, 2025
c3eddaf
default inference
justinchuby Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tests/optimizer/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@
from onnxscript.rewriter import onnxruntime as ort_rewriter
from onnxscript.utils import evaluation_utils

_SKIP_TABLE = {
"resnet18": "fixme: ORT aborts when loading the model - https://github.com/microsoft/onnxruntime/issues/24473",
"mobilenetv2_100": "fixme: ORT aborts when loading the model - https://github.com/microsoft/onnxruntime/issues/24473",
}
_SKIP_TABLE = {}

model_folder_path = (
pathlib.Path(__file__).resolve().parent.parent.parent / "testdata" / "e2e_models"
Expand All @@ -41,7 +38,7 @@ def test_model_runs_and_matches_accuracy_after_optimization(self, model_name):
if not model_path.exists():
self.skipTest(f"Model {model_name!r} does not exist")
model = onnx.load(model_path)
model = optimizer.optimize(model, onnx_shape_inference=False)
model = optimizer.optimize(model)

with tempfile.TemporaryDirectory() as tmp_folder:
tmp_folder = pathlib.Path(tmp_folder)
Expand Down
Loading